Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some templates not being replaced #447

Merged
merged 2 commits into from Oct 12, 2019

Conversation

@eramdam
Copy link
Owner

eramdam commented Oct 12, 2019

This implements @pixeldesu's trick to proxy the getHogan internal method in order to optionally grab our own modified mustache templates instead of the in-bundle one when possible.

Right now it seems safe but it might not be if the content of TD.mustaches and whatever is inside the modules start to drift apart but migration will be a hassle so I'll assume this stays safe for a while 馃

eramdam added 2 commits Oct 12, 2019
@eramdam eramdam merged commit a1c32c9 into master Oct 12, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@pixeldesu

This comment has been minimized.

Copy link
Contributor

pixeldesu commented Oct 12, 2019

As long as these templates are used (and I assume porting hundreds of templates to React components will take a sizable chunk of time) we should be save, this changes the method pulling templates and as long as something tries to get a template using this function, we can replace them/inject our own, basically.

@eramdam

This comment has been minimized.

Copy link
Owner Author

eramdam commented Oct 12, 2019

@pixeldesu yeah it should be safe all around, things might get funky if the in-bundle templates start to be way different from the TD.mustaches ones but 馃し鈥嶁檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.