Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upFix some templates not being replaced #447
Conversation
This comment has been minimized.
This comment has been minimized.
|
As long as these templates are used (and I assume porting hundreds of templates to React components will take a sizable chunk of time) we should be save, this changes the method pulling templates and as long as something tries to get a template using this function, we can replace them/inject our own, basically. |
This comment has been minimized.
This comment has been minimized.
|
@pixeldesu yeah it should be safe all around, things might get funky if the in-bundle templates start to be way different from the TD.mustaches ones but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
eramdam commentedOct 12, 2019
This implements @pixeldesu's trick to proxy the
getHoganinternal method in order to optionally grab our own modified mustache templates instead of the in-bundle one when possible.Right now it seems safe but it might not be if the content of🤞
TD.mustachesand whatever is inside the modules start to drift apart but migration will be a hassle so I'll assume this stays safe for a while