New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the 'Replace' view is visible when using 'Replace In Files' #1511

Closed
MaciejPolanski opened this Issue Jan 10, 2017 · 7 comments

Comments

Projects
None yet
2 participants
@MaciejPolanski

MaciejPolanski commented Jan 10, 2017

If "Replace" view disabled in Output View then the repalce in files, invoked by
Search->Find in Files->Find in Files.. then pressing "Replace"
fails for no obvious reason. Sometimes it focuses on previous Search, but not always.
Expected behaviour:
It should open "Replace" view (add it to Output view) then make replace.

Codelite v 10.0.0, Ubuntu 64bit + Xfce

@eranif

This comment has been minimized.

Show comment
Hide comment
@eranif

eranif Jan 10, 2017

Owner

Please provide a step by step how to reproduce this problem

Owner

eranif commented Jan 10, 2017

Please provide a step by step how to reproduce this problem

@MaciejPolanski

This comment has been minimized.

Show comment
Hide comment
@MaciejPolanski

MaciejPolanski Jan 10, 2017

  1. Have "Replace" view disabled in Output View (the one on bottom)
  2. Open menu Search
  3. Choose Find in Files
  4. Choose "Find in Files..."
  5. Set phrase to be replaced and press "Replace" button
    Silent failure, Replace view not opened in Output View

MaciejPolanski commented Jan 10, 2017

  1. Have "Replace" view disabled in Output View (the one on bottom)
  2. Open menu Search
  3. Choose Find in Files
  4. Choose "Find in Files..."
  5. Set phrase to be replaced and press "Replace" button
    Silent failure, Replace view not opened in Output View
@eranif

This comment has been minimized.

Show comment
Hide comment
@eranif

eranif Jan 10, 2017

Owner

I am unable to reproduce this here. Works as expected.
I suspect its something with the desktop manager. Can you try with different desktop manager? (GNOME, KDE, LXDE etc?)

Owner

eranif commented Jan 10, 2017

I am unable to reproduce this here. Works as expected.
I suspect its something with the desktop manager. Can you try with different desktop manager? (GNOME, KDE, LXDE etc?)

@MaciejPolanski

This comment has been minimized.

Show comment
Hide comment
@MaciejPolanski

MaciejPolanski Jan 11, 2017

It looks that problem is that results of "Replace" in "Find in files" goes to invisible window, making impression it does not work.

I just recorded my issue, to make sure you know what I am talking about:
https://youtu.be/_L-wvgrJ8NM

If it works for rest of the world, then just close it :)

MaciejPolanski commented Jan 11, 2017

It looks that problem is that results of "Replace" in "Find in files" goes to invisible window, making impression it does not work.

I just recorded my issue, to make sure you know what I am talking about:
https://youtu.be/_L-wvgrJ8NM

If it works for rest of the world, then just close it :)

@eranif

This comment has been minimized.

Show comment
Hide comment
@eranif

eranif Jan 11, 2017

Owner

In the output view, click on the 3 dots button on the top-right.
And select the "Replace" tab, this should work now for you

Owner

eranif commented Jan 11, 2017

In the output view, click on the 3 dots button on the top-right.
And select the "Replace" tab, this should work now for you

@eranif

This comment has been minimized.

Show comment
Hide comment
@eranif

eranif Jan 11, 2017

Owner

Lets change the subject to "Make sure the 'Replace' view is visible when using 'Replace In Files'"

Owner

eranif commented Jan 11, 2017

Lets change the subject to "Make sure the 'Replace' view is visible when using 'Replace In Files'"

@MaciejPolanski MaciejPolanski changed the title from Replace in Files doesn't work if Replace disabled in Output View to Make sure the 'Replace' view is visible when using 'Replace In Files' Jan 11, 2017

@MaciejPolanski

This comment has been minimized.

Show comment
Hide comment
@MaciejPolanski

MaciejPolanski Jan 11, 2017

Yes, that was a real cause of my issue, thanks.

MaciejPolanski commented Jan 11, 2017

Yes, that was a real cause of my issue, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment