Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FSW Workspace "Refresh" Icon operation is not identical to "Refresh" in context menu #3108

Closed
UffeJakobsen opened this issue Nov 30, 2022 · 3 comments
Assignees
Labels

Comments

@UffeJakobsen
Copy link
Contributor

What happened?

[Bug]: FSW Workspace "Refresh" Icon operation is not identical to "Refresh" in context menu

The "Refresh" Icon in the Workspace dock does perform the same operation as "Refresh" in the context menu (right click) - also in the Workspace dock...

Selecting "Refresh" in the context menu will refresh the file tree with respect to new and deleted file, dirs etc...
Hitting the "Refresh" Icon in the Workspace docs - won't perform the same - honestly I do not really know what is does...

Version

Self compiled

Operating system

Linux

Steps to reproduce

No response

Relevant log output

No response

@eranif
Copy link
Owner

eranif commented Dec 1, 2022

I just checked the code, in fact, clicking the Refresh icon in the small toolbar, will do the exact same thing as the context menu.
As you can see in this line:
https://github.com/eranif/codelite/blob/master/Plugin/clFileSystemWorkspaceView.cpp#L174

It will call clTreeCtrlPanel::OnRefresh(event); (which is the handler for the context menu).

I suspect that the difference is that when clicking the button, you must have a selected folder or file first in the tree view

@eranif
Copy link
Owner

eranif commented Dec 1, 2022

I did small change here, the new behavior is:

  • Choosing the "Refresh" from the context menu, refreshes the selected folder(s)
  • Clicking the "Refresh" button, refreshes the entire view, unconditionally

@eranif eranif closed this as completed in 7956b4c Dec 1, 2022
@UffeJakobsen
Copy link
Contributor Author

Thanks that sound like the right approach - will pull and it test now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants