Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find in Files dialog box is not focused when invoked #649

Closed
uffejakobsen opened this issue Feb 10, 2015 · 12 comments

Comments

Projects
None yet
2 participants
@uffejakobsen
Copy link

commented Feb 10, 2015

When opening the Find in Files Dialog box (in menu: Search/Find in Files) the dialog box is not focused.

Attempts to enter a search phrase will go into the editor window in the back - quite annoying :-)

Seen with Codelite 7.0 on ArchLinux

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2015

This is probably of the result of changing the FiF from Dialog -> Frame
The reason for this change is >> the focus issue: on OSX, you can "lose" it under the main window, while using a Frame I can set a flag "float-on-parent" to prevent it from going behind the main window

However, this works fine here on Linux Mint / Ubuntu at home
So I am not sure why ArchLinux is different

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 10, 2015

I think that the behaviour could be Desktop Environment/Window Manager dependant

On ArchLinux I'm using LXDE here (LXDE uses openbox WM behind the scenes).
Unfortunately I cannot try another Desktop Environment - due to diskspace limitation

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 10, 2015

Another observation: Dialogs like "Goto...", "Find Resource.." and "Quick Outline..." does NOT have the described problem on ArchLinux (LXDE)

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2015

This is because all of them are modal dialogs, while the Find In Files is a frame (which is modeless) based window

Eran

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 10, 2015

Ok - any reason for the special threatment with "Find In Files" ? I mean shouldn't that also be a modal dialog like the others ? or have I missed something ? :-)

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2015

It was always a modeless dialog (since codelite 1.X)
The change between CodeLite 6.1 and 7.0 is that the window hosting the find in files dialog is not a wxFrame (it used to be a wxDialog)
This change (switching from wxDialog to wxFrame) caused this behavior.

I will change it into a modal dialog and see how it goes ;)

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 10, 2015

Thanks :-) let me know if there is something that I should build and test for you

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 10, 2015

Sure. I am currently working on the caret line alpha issue ( I decided to replace this entire page if I am touching it ;) )

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2015

Fixed, please try it and confirm

@eranif eranif closed this Feb 11, 2015

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 11, 2015

The FiF is now focused - BUT the dialog is not resizeable - (could that be the original reason for choosing another window type ?)

The currently size of the dialog is so small that only the top of the Tabs in the Options: section are visible.

@eranif

This comment has been minimized.

Copy link
Owner

commented Feb 11, 2015

Fixed, a glitch when re-changing its type to wxDialog
You can do another git pull and it will be fixed

@uffejakobsen

This comment has been minimized.

Copy link
Author

commented Feb 11, 2015

Confirmed - now it works again - thanks :-)

@eranif eranif added this to the CodeLite 7.1 milestone Feb 13, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.