Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.2.0 Escrows #253

Merged
merged 59 commits into from Nov 23, 2019
Merged

v1.2.0 Escrows #253

merged 59 commits into from Nov 23, 2019

Conversation

thegostep
Copy link
Contributor

@thegostep thegostep commented Nov 5, 2019

Done

  • get rid of agreement metadata
  • events to distinguish each function
  • check if better way to pass in agreementFactory
  • check if possible to avoid agreementParams
  • check if possible to have roles module
  • create new deposit module to remove paymentAmount and stakeAmount (may need to be coupled with role)
  • rename status functions at lower level to clarify etherscan ABI and inheritance
  • check for current stake breaks if seller == buyer
  • should agreement inherit operator from escrow?
  • add state machine
  • gas benchmarks
  • use explicit return statements
  • Spawner as Library #281
  • getPunishment #276
  • solc 0.5.13 #270

WIP

Abandoned

  • generalize escrow execution and move functionality to a module

@erasureprotocol erasureprotocol deleted a comment from harsh103 Nov 5, 2019
@erasureprotocol erasureprotocol deleted a comment from harsh103 Nov 5, 2019
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Outdated Show resolved Hide resolved
contracts/escrows/CountdownGriefingEscrow.sol Show resolved Hide resolved
@thegostep thegostep requested a review from jparyani Nov 10, 2019
@thegostep thegostep merged commit 6a28933 into master Nov 23, 2019
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants