Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cp: optionally register component as provider #206

Merged
merged 3 commits into from Jan 14, 2022

Conversation

sfwn
Copy link
Member

@sfwn sfwn commented Jan 14, 2022

What this PR does / why we need it:

Sometimes, a component is a provider first, then become a component.
For this situation, we provide a more convenient method to use.

Previous:
image

Now:
image

Specified Reivewers:

/assign @Effet

@sfwn sfwn added the feature label Jan 14, 2022
@erda-bot erda-bot requested a review from Effet January 14, 2022 11:51
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #206 (6be1faf) into master (0c3ceab) will increase coverage by 0.33%.
The diff coverage is n/a.

❗ Current head 6be1faf differs from pull request most recent head 57138f2. Consider uploading reports for the commit 57138f2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
+ Coverage   38.45%   38.79%   +0.33%     
==========================================
  Files          75       73       -2     
  Lines        4545     4511      -34     
==========================================
+ Hits         1748     1750       +2     
+ Misses       2682     2647      -35     
+ Partials      115      114       -1     
Impacted Files Coverage Δ
...s/component-protocol/utils/cputil/provider_name.go 74.07% <ø> (ø)
...omponent-protocol/cpregister/base/comp_register.go
...onent-protocol/cpregister/base/default_provider.go
base/servicehub/hub.go 49.57% <0.00%> (+0.56%) ⬆️

@sfwn sfwn force-pushed the feature/cp-comp-as-provider branch from a9ebfd5 to 5c5ed22 Compare January 14, 2022 11:57
@Effet
Copy link
Member

Effet commented Jan 14, 2022

no demo changes?

@sfwn
Copy link
Member Author

sfwn commented Jan 14, 2022

no demo changes?

kanban demo simplified.

@Effet Effet merged commit 7476286 into erda-project:master Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

2 participants