Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix rails widget rendering to work with depends_on #30

Open
wants to merge 2 commits into
from

Conversation

Projects
None yet
3 participants

Currently the rails render widget code uses the view output buffer as the output buffer passed into Erector::Output. This causes the placeholder string to be copied into the output buffer as the header is rendered. This prevents the actual rendering of the dependencies from working later on in the process.

This change makes render widget use the default output buffer (an array) and then serializes it into the rails view output buffer when it's done.

@sublogical sublogical make the rails widget rendering code work with depends_on by not seri…
…alizing to string until after the dependencies have been rendered
7570ffd

alexch commented on 7570ffd Aug 12, 2012

This looks useful. Can you come up with a test scenario exposing this bug?

ajb commented Dec 19, 2013

Hey @sublogical, i'm currently working on a fork at https://github.com/adamjacobbecker/erector-rails4. I have an email in to Alex to see what we can do re: continuing support of this project. curious if you have a second -- can you provide some more details on how to recreate this bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment