Permalink
Switch branches/tags
Nothing to show
Commits on May 3, 2011
  1. Safe string encoding for access tokens

    nikreiman committed May 3, 2011
    This bugfix is actually copied from another github user (see
    facebook#292 for more details).
    Hopefully facebook will pull this fix, and we can revert this change in
    the future.
Commits on May 2, 2011
  1. Updated JSON SDK (fixes issue #295)

    nikreiman committed May 2, 2011
    Sources copied from json-framework, ref 8cabcf40ab1750ea6810818008256dbd744db71c, though Facebook should seriously consider using a git submodule there rather than a copy of the files. As this fix is specifically meant to update the compatibility of the Facebook-iOS-SDK to a recent version of the framework, I didn't feel that it was necessary to "force" Facebook to migrate to a git submodule at the same time, though I would encourage them to do so for obvious reasons.
    
    Thanks to @tinora for reporting this issue, and making the original fixes here which I have rolled into this commit. Hopefully, using a pull request will be a bit easier for Facebook to merge instead of a pasted diff in the issue. ;)
Commits on Apr 6, 2011
Commits on Jan 31, 2011
  1. Return FBRequest* from request: methods.

    Jim Brusstar committed Jan 31, 2011
    The request: selectors in the Facebook class now return a pointer to the
    instantiated FBRequest object (rather than void). This makes it easier
    to know in the delegate callback which request the callback maps to.
Commits on Dec 14, 2010
  1. fixing docs link

    bgold committed Dec 14, 2010
Commits on Dec 8, 2010
  1. Updates to README for platform dialogs.

    Jim Brusstar committed Dec 8, 2010
  2. Add app_id to dialog requests.

    Jim Brusstar committed Dec 8, 2010
    Updated the dialog() method to always include app_id. This will prevent
    an error if a dialog is requested and the application doesn't have an
    access token. App_id must now be specified in the Facebook constructor
    as this saves specifying it with every request. Xcode project has been
    updated to build with iOS SDK 4.3.
Commits on Dec 2, 2010
  1. Platform Dialogs Support (UIServer Pretty URLs)

    Jim Brusstar committed Nov 17, 2010
Commits on Dec 1, 2010
  1. added an anchor to dialogs

    bgold committed Dec 1, 2010
Commits on Nov 30, 2010
  1. Prevent dismissWithSuccess:animated from being called twice

    Yariv Sadan committed with Yariv Sadan Nov 30, 2010
    Summary:
    see https://github.com/facebook/facebook-ios-sdk/issues#issue/161
    
    Test Plan:
    verified it was called only once
    
    DiffCamp Revision: 186903
    Reviewed By: brent
    CC: brent
    Revert Plan:
    OK
Commits on Nov 23, 2010
  1. Adding note about plist

    mvernal committed Nov 23, 2010
  2. Clarifying start instructions

    mvernal committed Nov 23, 2010
Commits on Nov 11, 2010
  1. fix the readme formatting

    Yariv Sadan committed Nov 11, 2010
Commits on Nov 9, 2010
  1. Fix the way the SDK interprets UIWebViewDelegate errors

    Yariv Sadan committed with Yariv Sadan Nov 9, 2010
    Summary:
    Currently if the facebook app encounters a UIWebViewDelegate error, it passes
    it to the sdk in the error_code parameter. The SDK should know that if this
    parameter is passed, an error occurred, which implies the user *didn't* cancel.
    This fixes it.
    
    Test Plan:
    disconnected my laptop from the internet, went through the sso flow, verified
    the sdk set userDidCancel to NO before calling [self
    fbDialogNotLogin:userDidCancel].
    
    DiffCamp Revision: 180310
    Reviewed By: brent
    CC: brent
    Revert Plan:
    OK
Commits on Nov 8, 2010
  1. Updates to README.

    Jim Brusstar committed Nov 5, 2010
    Summary:
    Edits to the documentation for clarity and grammar. This brings
    documentation more in line with Android SDK for consistency.
    
    Reviewers:
    yariv
    
    CC:
    arunv, brent, lshepard
    
    Test Plan:
    All comments--no impact on code.
    
    DiffCamp Revision: 179248
Commits on Nov 5, 2010
  1. Removing theRunAround Sample App.

    Jim Brusstar committed Nov 5, 2010
    Summary:
    It wasn't particularly useful, so it gets the rm -rf.
    
    Test Plan:
    Nothing depended on this, so we're good.
    
    DiffCamp Revision: 179177
    Reviewed By: yariv
    CC: arunv, lshepard, brent, rmcelroy, arice, achao, yariv, bootcamp-diffs@lists
    Tasks:
    #431037: Go start-to-finish through iOS SDK and validate
    
    Revert Plan:
    OK
  2. Make theRunAround use SSO

    Yariv Sadan committed with Yariv Sadan Nov 5, 2010
    Summary: n/a
    
    Task ID: #
    
    Blame Rev:
    
    Reviewers: brent, jbrusstar, lshepard, arunv
    
    CC:
    
    Test Plan: verified login via SSO worked
    
    Revert Plan:
    
    Tags:
    
    - begin *PUBLIC* platform impact section -
    Bugzilla: #
    - end platform impact -
    
    DiffCamp Revision: 179100
  3. iOS single sign on

    Yariv Sadan committed Nov 5, 2010
    Summary:
    This diff implements single sign-on for iOS.
    
    Test Plan:
    n/a
    
    DiffCamp Revision: 179082
    Reviewed By: brent
    CC: brent, arice, yariv
    Revert Plan:
    OK
Commits on Oct 14, 2010
  1. iOS SDK sample app 'theRunAround' modified to only show friends using…

    Vikas Gupta committed Oct 14, 2010
    … the app.
    
    Summary:
    The app before showed all your friends regardless of if they were using this
    app.
    
    With this diff, only friends who are or have used the app will be shown in the
    list.
    
    Test Plan:
    Run the app with an app id which only some of your friends are using and only
    those friends should show in the friends list.
    
    DiffCamp Revision: 169803
    Reviewed By: brent
    CC: brent
    Revert Plan:
    OK
Commits on Sep 23, 2010
  1. iOS SDK: fix memory issue in SDK and theRunAround demo App

    Yujuan Bao committed Sep 23, 2010
    summary:
    Fix some memory leak and dealloc issues
    
    The Facebook.m -logout: method calls this:
    
    [self requestWithMethodName:@"auth.expireSession"
    andParams:params andHttpMethod:@"GET"
    andDelegate:self];
    
    By setting the Facebook object as the delegate, it gets retained by the FBRequest object, but in turn the -openUrl:params:httpMethod:delegate: method retains the request itself in the _request instance variable. This creates a retain cycle, and neither object will be freed.
    
    -in Session.m, there is a missing retain on the uid in -restore -in Session.m there is no dealloc method — one should be added to free facebook and uid -in UserInfo.m, the dealloc needs to release the userInfoDelegate that was retained -in UserRequestResult.m there is no dealloc — one should be added to free userRequestDelegate
    
    test plan:
    theRunAroundDemoApp, open the app login and turn off the app without log out. bring the app up again. make sure we are logged in and all the session info bring back correctly.
    
    Run the unittest
Commits on Sep 20, 2010
Commits on Sep 13, 2010
  1. iOS SDK: fix a few issues

    Yujuan Bao committed Sep 13, 2010
Commits on Sep 9, 2010
  1. iOS SDK: Use the new set of button image

    Yujuan Bao committed Sep 9, 2010
Commits on Sep 1, 2010
  1. iOS SDK:Facebook delegate fbDidNotLogin add a parameter to check if u…

    Yujuan Bao committed Sep 1, 2010
    …ser cancel and address several other issue
Commits on Aug 26, 2010
Commits on Aug 25, 2010
  1. ios sdk: remove an extra retain and a warning msg

    Yujuan Bao committed Aug 25, 2010
Commits on Aug 20, 2010
Commits on Aug 19, 2010
  1. ios sdk :a fix on url encode at FBRequest.m

    Yujuan Bao committed Aug 19, 2010
Commits on Aug 17, 2010
  1. iOS sdk : clean up some mess around the README file

    Yujuan Bao committed Aug 17, 2010
Commits on Aug 16, 2010
  1. ios sdk :a fix on url encode

    Yujuan Bao committed Aug 16, 2010
Commits on Aug 15, 2010
  1. Fix link formatting.

    Luke Shepard committed Aug 15, 2010
  2. Modifications to README. Fixing formatting.

    Luke Shepard committed Aug 15, 2010
Commits on Aug 13, 2010
  1. change the delegate name

    Yujuan Bao committed Aug 13, 2010
Commits on Aug 12, 2010
  1. fix readme file

    Yujuan Bao committed Aug 12, 2010