Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize crates #4

Closed
cm-ayf opened this issue Aug 12, 2022 · 1 comment
Closed

Organize crates #4

cm-ayf opened this issue Aug 12, 2022 · 1 comment

Comments

@cm-ayf
Copy link

cm-ayf commented Aug 12, 2022

Currently, following crates are found:

  • erg_common: /src/erg_common
  • erg_compiler: /src/erg_compiler
  • erg_parser: /src/erg_compiler/erg_paraser

These crates should be organized in a good manner; for example, create /workspaces/ (or /complier/?) and put all crates there.

Also, these crates should be managed by Cargo's workspace feature.

refer to: rust-lang/rust directory structure

@mtshiba
Copy link
Member

mtshiba commented Aug 12, 2022

I created the organize_crates branch and added the workspace.
This looks good, Rust-analyzer can now detect errors in the erg_parser test file.

Thank you for your suggestion.

@mtshiba mtshiba closed this as completed Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants