Skip to content
Permalink
Browse files

Merge pull request #15 from ergebnis/fix/repository

Fix: Remove Repository with locking capabilities
  • Loading branch information
localheinz committed Mar 8, 2020
2 parents 0248e3d + e1e8554 commit 736ffcedc4b2675ae79d2d10bb36c6c4799885a2
@@ -9,8 +9,8 @@ on: # yamllint disable-line rule:truthy
- "master"

env:
MIN_COVERED_MSI: 91
MIN_MSI: 45
MIN_COVERED_MSI: 92
MIN_MSI: 60
REQUIRED_PHP_EXTENSIONS: "mbstring"

jobs:
@@ -18,6 +18,7 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
* Removed possibility to set the entity namespace on the `FixtureFactory` ([#3]), by [@localheinz]
* Removed `StatusArrayType` ([#13]), by [@localheinz]
* Removed `FieldDef::past()`, `FieldDef::future()`, and `DateIntervalHelper` ([#14]), by [@localheinz]
* Removed `Repository` along with locking capabilities ([#15]), by [@localheinz]

[fa9c564...master]: https://github.com/ergebnis/factory-bot/compare/fa9c564...master

@@ -26,5 +27,6 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
[#6]: https://github.com/ergebnis/factory-bot/pull/6
[#13]: https://github.com/ergebnis/factory-bot/pull/13
[#14]: https://github.com/ergebnis/factory-bot/pull/14
[#15]: https://github.com/ergebnis/factory-bot/pull/15

[@localheinz]: https://github.com/localheinz
@@ -1,5 +1,5 @@
MIN_COVERED_MSI:=91
MIN_MSI:=45
MIN_COVERED_MSI:=92
MIN_MSI:=60

.PHONY: it
it: coding-standards dependency-analysis static-code-analysis tests ## Runs the coding-standards, dependency-analysis, static-code-analysis, and tests targets
@@ -265,91 +265,6 @@ parameters:
count: 1
path: src/Doctrine/FixtureFactory.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/LockException.php

-
message: "#^Class \"FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\LockException\" is not allowed to extend \"Exception\"\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/LockException.php

-
message: "#^Class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\LockException is neither abstract nor final\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/LockException.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\TableLock is neither abstract nor final\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Parameter \\$transaction of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\TableLock\\:\\:transaction\\(\\) has invalid typehint type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\callback\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Parameter \\$em of anonymous function has invalid typehint type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\EntityManager\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Call to method getConnection\\(\\) on an unknown class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\EntityManager\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Caught class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\Exception not found\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Throwing object of an unknown class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\Exception\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Only booleans are allowed in a negated boolean, string\\|null given\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^Call to protected method getClassMetadata\\(\\) of class Doctrine\\\\ORM\\\\EntityRepository\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLock.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLockMode.php

-
message: "#^Class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\TableLockMode is neither abstract nor final\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLockMode.php

-
message: "#^Control structures using switch should not be used\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLockMode.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\TableLockMode\\:\\:toString\\(\\) should return string\\|null but return statement is missing\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/TableLockMode.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/Locking/VersionLockable.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
@@ -470,176 +385,6 @@ parameters:
count: 2
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Class \"FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\" is not allowed to extend \"Doctrine\\\\ORM\\\\EntityRepository\"\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository is neither abstract nor final\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:getSingleQueryResult\\(\\) has parameter \\$fallback with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:getSingleQueryResult\\(\\) has parameter \\$fallback with null as default value\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(Exception\\) \\$fallback optional\\)\\: Unexpected token \"\\(\", expected variable at offset 76$#"
count: 2
path: src/Doctrine/ORM/Repository.php

-
message: "#^Parameter \\#1 \\$do of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:attemptQuery\\(\\) expects FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback, Closure\\(\\)\\: mixed given\\.$#"
count: 2
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:getSingleScalarQueryResult\\(\\) has parameter \\$fallback with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:getSingleScalarQueryResult\\(\\) has parameter \\$fallback with null as default value\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:attemptQuery\\(\\) has parameter \\$fallback with null as default value\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Parameter \\$do of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:attemptQuery\\(\\) has invalid typehint type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Parameter \\$fallback of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:attemptQuery\\(\\) has invalid typehint type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Anonymous function should have native return typehint \"void\"\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Invoking callable on an unknown class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback\\.$#"
count: 3
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:withQueryBuilder\\(\\) has parameter \\$do with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(QueryBuilder, Doctrine\\\\ORM\\\\Query\\\\Expr\\) \\$do\\)\\: Unexpected token \"\\(\", expected variable at offset 244$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:getReference\\(\\) should return object but returns object\\|null\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:transaction\\(\\) has parameter \\$transaction with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(Doctrine\\\\ORM\\\\EntityManager, Repository\\) \\$transaction\\)\\: Unexpected token \"\\(\", expected variable at offset 221$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @throws with type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Exception is not subtype of Throwable$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Caught class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Exception not found\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Call to method Doctrine\\\\DBAL\\\\Connection\\:\\:rollBack\\(\\) with incorrect case\\: rollback$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Throwing object of an unknown class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Exception\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:useWithLock\\(\\) has parameter \\$callback with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(\\$entity, Doctrine\\\\ORM\\\\EntityManager, Repository\\) \\$callback\\)\\: Unexpected token \"\\(\", expected variable at offset 253$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Language construct empty\\(\\) should not be used\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:useWithPessimisticWriteLock\\(\\) has parameter \\$callback with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(\\$entity, Doctrine\\\\ORM\\\\EntityManager, Repository\\) \\$callback\\)\\: Unexpected token \"\\(\", expected variable at offset 117$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:useWithPessimisticVersionLock\\(\\) has parameter \\$callback with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(\\$entity, Doctrine\\\\ORM\\\\EntityManager, Repository\\) \\$callback\\)\\: Unexpected token \"\\(\", expected variable at offset 575$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Call to an undefined static method Doctrine\\\\ORM\\\\OptimisticLockException\\:\\:lockFailedVersionMissmatch\\(\\)\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Parameter \\$transaction of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Repository\\:\\:transactionWithTableLock\\(\\) has invalid typehint type FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Parameter \\#2 \\$transaction of method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\TableLock\\:\\:transaction\\(\\) expects FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\Locking\\\\callback, FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\callback given\\.$#"
count: 1
path: src/Doctrine/ORM/Repository.php

-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) with 'OutOfRangeException' and FactoryGirl\\\\Provider\\\\Doctrine\\\\EntityDefinitionUnavailable will always evaluate to true\\.$#"
count: 1
@@ -1210,51 +955,6 @@ parameters:
count: 1
path: test/Doctrine/Fixtures/TransitiveReferencesTest.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: test/Doctrine/ORM/RepositoryTest.php

-
message: "#^Class \"FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\RepositoryTest\" is not allowed to extend \"FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\TestCase\"\\.$#"
count: 1
path: test/Doctrine/ORM/RepositoryTest.php

-
message: "#^Class FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\RepositoryTest is neither abstract nor final\\.$#"
count: 1
path: test/Doctrine/ORM/RepositoryTest.php

-
message: "#^Method FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\RepositoryTest\\:\\:getsReference\\(\\) has no return typehint specified\\.$#"
count: 1
path: test/Doctrine/ORM/RepositoryTest.php

-
message: "#^Dynamic call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\)\\.$#"
count: 1
path: test/Doctrine/ORM/RepositoryTest.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: test/Doctrine/ORM/TestCase.php

-
message: "#^Method FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\TestCase\\:\\:setUp\\(\\) is not final, but since the containing class is abstract, it should be\\.$#"
count: 1
path: test/Doctrine/ORM/TestCase.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: test/Doctrine/ORM/TestEntity/User.php

-
message: "#^Property FactoryGirl\\\\Tests\\\\Provider\\\\Doctrine\\\\ORM\\\\TestEntity\\\\User\\:\\:\\$id has no typehint specified\\.$#"
count: 1
path: test/Doctrine/ORM/TestEntity/User.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1

0 comments on commit 736ffce

Please sign in to comment.
You can’t perform that action at this time.