From c1182d82fb19db3cf304afaef67a40373c8480fd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20M=C3=B6ller?= Date: Wed, 5 Aug 2020 15:12:46 +0200 Subject: [PATCH] Fix: Method names --- test/Unit/FieldDefinitionTest.php | 10 +++++----- .../Unit/FixtureFactory/UsingDefaultStrategyTest.php | 12 ++++++------ .../FixtureFactory/UsingWithOptionalStrategyTest.php | 12 ++++++------ 3 files changed, 17 insertions(+), 17 deletions(-) diff --git a/test/Unit/FieldDefinitionTest.php b/test/Unit/FieldDefinitionTest.php index 8c5a22c0..c3af856c 100644 --- a/test/Unit/FieldDefinitionTest.php +++ b/test/Unit/FieldDefinitionTest.php @@ -37,7 +37,7 @@ */ final class FieldDefinitionTest extends AbstractTestCase { - public function testClosureReturnsRequiredClosure(): void + public function testClosureReturnsClosure(): void { $closure = static function (Generator $faker, FixtureFactory $fixtureFactory): Entity\User { /** @var Entity\User $user */ @@ -73,7 +73,7 @@ public function testOptionalClosureReturnsOptionalClosure(): void self::assertEquals($expected, $fieldDefinition); } - public function testReferenceReturnsRequiredReference(): void + public function testReferenceReturnsReference(): void { $className = Entity\User::class; @@ -136,7 +136,7 @@ public function testSequenceRejectsValueWhenItIsMissingPercentDPlaceholder(): vo ); } - public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderAndInitialNumberIsNotSpecified(): void + public function testSequenceReturnsSequenceWhenValueContainsPlaceholderAndInitialNumberIsNotSpecified(): void { $value = 'there-is-no-difference-between-%d-and-%d'; @@ -155,7 +155,7 @@ public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderA * * @param int $initialNumber */ - public function testSequenceReturnsRequiredSequenceWhenValueContainsPlaceholderAndInitialNumberIsSpecified(int $initialNumber): void + public function testSequenceReturnsSequenceWhenValueContainsPlaceholderAndInitialNumberIsSpecified(int $initialNumber): void { $value = 'there-is-no-difference-between-%d-and-%d'; @@ -232,7 +232,7 @@ public function testOptionalSequenceReturnsOptionalSequenceWhenValueContainsPlac * * @param mixed $value */ - public function testValueReturnsRequiredValue($value): void + public function testValueReturnsValue($value): void { $fieldDefinition = FieldDefinition::value($value); diff --git a/test/Unit/FixtureFactory/UsingDefaultStrategyTest.php b/test/Unit/FixtureFactory/UsingDefaultStrategyTest.php index 3045fed4..77c484eb 100644 --- a/test/Unit/FixtureFactory/UsingDefaultStrategyTest.php +++ b/test/Unit/FixtureFactory/UsingDefaultStrategyTest.php @@ -81,7 +81,7 @@ public function testCreateOneResolvesOptionalClosureToResultOfClosureInvokedWith self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void + public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -102,7 +102,7 @@ public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWith self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void + public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -161,7 +161,7 @@ public function testCreateOneResolvesOptionalReferenceToEntityWhenFakerReturnsTr self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFalse(): void + public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -180,7 +180,7 @@ public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFa self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsTrue(): void + public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -371,7 +371,7 @@ public function testCreateOneResolvesOptionalSequenceToStringValueWhenPercentDPl self::assertSame('City (3)', $userThree->location()); } - public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void + public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -396,7 +396,7 @@ public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPl self::assertSame('City (3)', $userThree->location()); } - public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void + public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), diff --git a/test/Unit/FixtureFactory/UsingWithOptionalStrategyTest.php b/test/Unit/FixtureFactory/UsingWithOptionalStrategyTest.php index 5cc7f8e8..04356902 100644 --- a/test/Unit/FixtureFactory/UsingWithOptionalStrategyTest.php +++ b/test/Unit/FixtureFactory/UsingWithOptionalStrategyTest.php @@ -86,7 +86,7 @@ public function testCreateOneResolvesOptionalClosureToResultOfClosureInvokedWith self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void + public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -109,7 +109,7 @@ public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWith self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void + public function testCreateOneResolvesClosureToResultOfClosureInvokedWithFakerAndFixtureFactoryWhenFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -174,7 +174,7 @@ public function testCreateOneResolvesOptionalReferenceToEntityWhenFakerReturnsTr self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFalse(): void + public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -195,7 +195,7 @@ public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsFa self::assertInstanceOf(Entity\CodeOfConduct::class, $repository->codeOfConduct()); } - public function testCreateOneResolvesRequiredReferenceToEntityWhenFakerReturnsTrue(): void + public function testCreateOneResolvesReferenceToEntityWhenFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -408,7 +408,7 @@ public function testCreateOneResolvesOptionalSequenceToStringValueWhenPercentDPl self::assertSame('City (3)', $userThree->location()); } - public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void + public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsFalse(): void { $fixtureFactory = new FixtureFactory( self::entityManager(), @@ -435,7 +435,7 @@ public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPl self::assertSame('City (3)', $userThree->location()); } - public function testCreateOneResolvesRequiredSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void + public function testCreateOneResolvesSequenceToStringValueWhenPercentDPlaceholderIsPresentAndFakerReturnsTrue(): void { $fixtureFactory = new FixtureFactory( self::entityManager(),