Skip to content
Permalink
Browse files

Merge pull request #16 from ergebnis/fix/query-builder

Fix: Remove QueryBuilder
  • Loading branch information
localheinz committed Mar 9, 2020
2 parents 736ffce + 78927ac commit d10b37b8085c0e7a111f8d38de906c9789991470
@@ -17,8 +17,6 @@ update_configs:
dependency_name: "doctrine/annotations"
- match:
dependency_name: "doctrine/collections"
- match:
dependency_name: "doctrine/dbal"
- match:
dependency_name: "doctrine/orm"
package_manager: "php:composer"
@@ -10,7 +10,7 @@ on: # yamllint disable-line rule:truthy

env:
MIN_COVERED_MSI: 92
MIN_MSI: 60
MIN_MSI: 70
REQUIRED_PHP_EXTENSIONS: "mbstring"

jobs:
@@ -19,6 +19,7 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
* Removed `StatusArrayType` ([#13]), by [@localheinz]
* Removed `FieldDef::past()`, `FieldDef::future()`, and `DateIntervalHelper` ([#14]), by [@localheinz]
* Removed `Repository` along with locking capabilities ([#15]), by [@localheinz]
* Removed `QueryBuilder` ([#16]), by [@localheinz]

[fa9c564...master]: https://github.com/ergebnis/factory-bot/compare/fa9c564...master

@@ -28,5 +29,6 @@ For a full diff see [`fa9c564...master`][fa9c564...master].
[#13]: https://github.com/ergebnis/factory-bot/pull/13
[#14]: https://github.com/ergebnis/factory-bot/pull/14
[#15]: https://github.com/ergebnis/factory-bot/pull/15
[#16]: https://github.com/ergebnis/factory-bot/pull/16

[@localheinz]: https://github.com/localheinz
@@ -1,5 +1,5 @@
MIN_COVERED_MSI:=92
MIN_MSI:=60
MIN_MSI:=70

.PHONY: it
it: coding-standards dependency-analysis static-code-analysis tests ## Runs the coding-standards, dependency-analysis, static-code-analysis, and tests targets
@@ -19,7 +19,6 @@
"php": "^7.2",
"doctrine/annotations": "^1.7.0",
"doctrine/collections": "^1.0.0",
"doctrine/dbal": "^2.2.1",
"doctrine/orm": "^2.6.3",
"ergebnis/classy": "~0.5.2",
"fzaninotto/faker": "^1.9.1"

Some generated files are not rendered by default. Learn more.

@@ -265,126 +265,6 @@ parameters:
count: 1
path: src/Doctrine/FixtureFactory.php

-
message: "#^File is missing a \"declare\\(strict_types\\=1\\)\" declaration\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Class \"FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\" is not allowed to extend \"Doctrine\\\\ORM\\\\QueryBuilder\"\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Class FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder is neither abstract nor final\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^PHPDoc tag @var has invalid value \\(array\\<string \\=\\> boolean\\>\\)\\: Unexpected token \"\\=\\>\", expected '\\>' at offset 29$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Property FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:\\$_statuses has no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^PHPDoc tag @var has invalid value \\(array\\<callback\\(Query\\)\\>\\)\\: Unexpected token \"\\(\", expected '\\>' at offset 30$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Property FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:\\$_queryConfigurers has no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Unsafe usage of new static\\(\\)\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Constructor in FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder has parameter \\$entityAlias with default value\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Constructor in FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder has parameter \\$entityName with default value\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:__construct\\(\\) has parameter \\$entityAlias with null as default value\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:__construct\\(\\) has parameter \\$entityName with null as default value\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Property FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:\\$entityName \\(string\\) does not accept string\\|null\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Property FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:\\$entityAlias \\(string\\) does not accept string\\|null\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:init\\(\\) has no return typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Call to function is_string\\(\\) with string will always evaluate to true\\.$#"
count: 2
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Result of && is always true\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:_configureQuery\\(\\) has parameter \\$configurer with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(Doctrine\\\\ORM\\\\Query\\) \\$configurer\\)\\: Unexpected token \"\\(\", expected variable at offset 66$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Method FactoryGirl\\\\Provider\\\\Doctrine\\\\ORM\\\\QueryBuilder\\:\\:ensure\\(\\) has parameter \\$operation with no typehint specified\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^PHPDoc tag @param has invalid value \\(callback\\(QueryBuilder\\) \\$operation\\)\\: Unexpected token \"\\(\", expected variable at offset 916$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Language construct empty\\(\\) should not be used\\.$#"
count: 1
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Anonymous function should have native return typehint \"void\"\\.$#"
count: 2
path: src/Doctrine/ORM/QueryBuilder.php

-
message: "#^Call to static method PHPUnit\\\\Framework\\\\Assert\\:\\:assertInstanceOf\\(\\) with 'OutOfRangeException' and FactoryGirl\\\\Provider\\\\Doctrine\\\\EntityDefinitionUnavailable will always evaluate to true\\.$#"
count: 1
@@ -158,36 +158,6 @@
<code>getAssociationMapping</code>
</MixedMethodCall>
</file>
<file src="src/Doctrine/ORM/QueryBuilder.php">
<InvalidDocblock occurrences="4">
<code>protected $_statuses = [];</code>
<code>protected $_queryConfigurers = [];</code>
<code>callback(Doctrine\ORM\Query)</code>
<code>callback(QueryBuilder)</code>
</InvalidDocblock>
<MissingParamType occurrences="2">
<code>$configurer</code>
<code>$operation</code>
</MissingParamType>
<MissingReturnType occurrences="1">
<code>init</code>
</MissingReturnType>
<MixedAssignment occurrences="1">
<code>$configurer</code>
</MixedAssignment>
<MixedFunctionCall occurrences="2">
<code>$configurer($query)</code>
<code>$operation($this)</code>
</MixedFunctionCall>
<PossiblyNullPropertyAssignmentValue occurrences="2">
<code>$entityName</code>
<code>$entityAlias</code>
</PossiblyNullPropertyAssignmentValue>
<RedundantConditionGivenDocblockType occurrences="2">
<code>is_string($this-&gt;entityName)</code>
<code>is_string($this-&gt;entityAlias)</code>
</RedundantConditionGivenDocblockType>
</file>
<file src="test/Doctrine/Fixtures/BasicUsageTest.php">
<MissingReturnType occurrences="12">
<code>acceptsConstantValuesInEntityDefinitions</code>

This file was deleted.

@@ -37,7 +37,6 @@ public function testSrcClassesHaveUnitTests(): void
Doctrine\EntityDefinitionUnavailable::class,
Doctrine\FieldDef::class,
Doctrine\FixtureFactory::class,
Doctrine\ORM\QueryBuilder::class,
]
);
}

0 comments on commit d10b37b

Please sign in to comment.
You can’t perform that action at this time.