From 5a5c54bed3f24adc35d32d0dd4c46647afff9e12 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Andreas=20M=C3=B6ller?= <am@localheinz.com>
Date: Sat, 4 May 2024 14:11:25 +0200
Subject: [PATCH] Enhancement: Extract FieldValueResolutionStrategy interface

---
 src/FieldResolution/DefaultStrategy.php       |  2 +-
 .../FieldValueResolutionStrategy.php          | 33 +++++++++++++++++++
 src/FieldResolution/ResolutionStrategy.php    | 11 -------
 src/FieldResolution/WithOptionalStrategy.php  |  2 +-
 .../WithoutOptionalStrategy.php               |  2 +-
 src/FixtureFactory.php                        |  6 +++-
 6 files changed, 41 insertions(+), 15 deletions(-)
 create mode 100644 src/FieldResolution/FieldValueResolutionStrategy.php

diff --git a/src/FieldResolution/DefaultStrategy.php b/src/FieldResolution/DefaultStrategy.php
index 26505655..51378dd2 100644
--- a/src/FieldResolution/DefaultStrategy.php
+++ b/src/FieldResolution/DefaultStrategy.php
@@ -21,7 +21,7 @@
 /**
  * @internal
  */
-final class DefaultStrategy implements ResolutionStrategy
+final class DefaultStrategy implements FieldValueResolutionStrategy, ResolutionStrategy
 {
     public function resolveFieldValue(
         Generator $faker,
diff --git a/src/FieldResolution/FieldValueResolutionStrategy.php b/src/FieldResolution/FieldValueResolutionStrategy.php
new file mode 100644
index 00000000..379d93ee
--- /dev/null
+++ b/src/FieldResolution/FieldValueResolutionStrategy.php
@@ -0,0 +1,33 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * Copyright (c) 2020-2024 Andreas Möller
+ *
+ * For the full copyright and license information, please view
+ * the LICENSE.md file that was distributed with this source code.
+ *
+ * @see https://github.com/ergebnis/factory-bot
+ */
+
+namespace Ergebnis\FactoryBot\FieldResolution;
+
+use Ergebnis\FactoryBot\FieldDefinition;
+use Ergebnis\FactoryBot\FixtureFactory;
+use Faker\Generator;
+
+/**
+ * @internal
+ */
+interface FieldValueResolutionStrategy
+{
+    /**
+     * @return mixed
+     */
+    public function resolveFieldValue(
+        Generator $faker,
+        FixtureFactory $fixtureFactory,
+        FieldDefinition\Resolvable $fieldDefinition,
+    );
+}
diff --git a/src/FieldResolution/ResolutionStrategy.php b/src/FieldResolution/ResolutionStrategy.php
index ddee00f5..793e89d3 100644
--- a/src/FieldResolution/ResolutionStrategy.php
+++ b/src/FieldResolution/ResolutionStrategy.php
@@ -14,8 +14,6 @@
 namespace Ergebnis\FactoryBot\FieldResolution;
 
 use Ergebnis\FactoryBot\Count;
-use Ergebnis\FactoryBot\FieldDefinition;
-use Ergebnis\FactoryBot\FixtureFactory;
 use Faker\Generator;
 
 /**
@@ -23,15 +21,6 @@
  */
 interface ResolutionStrategy
 {
-    /**
-     * @return mixed
-     */
-    public function resolveFieldValue(
-        Generator $faker,
-        FixtureFactory $fixtureFactory,
-        FieldDefinition\Resolvable $fieldDefinition,
-    );
-
     public function resolveCount(
         Generator $faker,
         Count $count,
diff --git a/src/FieldResolution/WithOptionalStrategy.php b/src/FieldResolution/WithOptionalStrategy.php
index 9ebb3edd..c99c4d5a 100644
--- a/src/FieldResolution/WithOptionalStrategy.php
+++ b/src/FieldResolution/WithOptionalStrategy.php
@@ -21,7 +21,7 @@
 /**
  * @internal
  */
-final class WithOptionalStrategy implements ResolutionStrategy
+final class WithOptionalStrategy implements FieldValueResolutionStrategy, ResolutionStrategy
 {
     public function resolveFieldValue(
         Generator $faker,
diff --git a/src/FieldResolution/WithoutOptionalStrategy.php b/src/FieldResolution/WithoutOptionalStrategy.php
index 5e4c50ca..e339140e 100644
--- a/src/FieldResolution/WithoutOptionalStrategy.php
+++ b/src/FieldResolution/WithoutOptionalStrategy.php
@@ -21,7 +21,7 @@
 /**
  * @internal
  */
-final class WithoutOptionalStrategy implements ResolutionStrategy
+final class WithoutOptionalStrategy implements FieldValueResolutionStrategy, ResolutionStrategy
 {
     public function resolveFieldValue(
         Generator $faker,
diff --git a/src/FixtureFactory.php b/src/FixtureFactory.php
index 4c2baf82..01bc490c 100644
--- a/src/FixtureFactory.php
+++ b/src/FixtureFactory.php
@@ -20,6 +20,7 @@
 
 final class FixtureFactory
 {
+    private FieldResolution\FieldValueResolutionStrategy $fieldValueResolutionStrategy;
     private FieldResolution\ResolutionStrategy $resolutionStrategy;
     private bool $persistAfterCreate = false;
 
@@ -32,6 +33,7 @@ public function __construct(
         private ORM\EntityManagerInterface $entityManager,
         private Generator $faker,
     ) {
+        $this->fieldValueResolutionStrategy = new FieldResolution\DefaultStrategy();
         $this->resolutionStrategy = new FieldResolution\DefaultStrategy();
     }
 
@@ -239,7 +241,7 @@ public function createOne(
         );
 
         $fieldValues = \array_map(function (FieldDefinition\Resolvable $fieldDefinition) {
-            return $this->resolutionStrategy->resolveFieldValue(
+            return $this->fieldValueResolutionStrategy->resolveFieldValue(
                 $this->faker,
                 $this,
                 $fieldDefinition,
@@ -325,6 +327,7 @@ public function withOptional(): self
     {
         $instance = clone $this;
 
+        $instance->fieldValueResolutionStrategy = new FieldResolution\WithOptionalStrategy();
         $instance->resolutionStrategy = new FieldResolution\WithOptionalStrategy();
 
         return $instance;
@@ -342,6 +345,7 @@ public function withoutOptional(): self
     {
         $instance = clone $this;
 
+        $instance->fieldValueResolutionStrategy = new FieldResolution\WithoutOptionalStrategy();
         $instance->resolutionStrategy = new FieldResolution\WithoutOptionalStrategy();
 
         return $instance;