Merge pull request #715 from ergebnis/fix/private-in-final-class

Fix: Add test case
ergebnis · Jan 23, 2024 · a6a8ba8 · a6a8ba8
2 parents 18154dc + 6cd556c
commit a6a8ba8
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/...ixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithProtectedMethodFromTrait.php b/...ixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithProtectedMethodFromTrait.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\PrivateInFinalClassRule\Success;
+
+final class FinalClassWithProtectedMethodFromTrait
+{
+    use TraitWithProtectedMethod;
+}
diff --git a/test/Fixture/Methods/PrivateInFinalClassRule/Success/TraitWithProtectedMethod.php b/test/Fixture/Methods/PrivateInFinalClassRule/Success/TraitWithProtectedMethod.php
@@ -0,0 +1,12 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Ergebnis\PHPStan\Rules\Test\Fixture\Methods\PrivateInFinalClassRule\Success;
+
+trait TraitWithProtectedMethod
+{
+    protected function method(): void
+    {
+    }
+}
diff --git a/test/Integration/Methods/PrivateInFinalClassRuleTest.php b/test/Integration/Methods/PrivateInFinalClassRuleTest.php
@@ -29,6 +29,7 @@ public static function provideCasesWhereAnalysisShouldSucceed(): iterable
             'final-class-with-private-method' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithPrivateMethod.php',
             'final-class-with-protected-method-extending-class-extending-class-with-same-protected-method' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithProtectedMethodExtendingClassExtendingClassWithSameProtectedMethod.php',
             'final-class-with-protected-method-extending-class-with-same-protected-method' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithProtectedMethodExtendingClassWithSameProtectedMethod.php',
+            'final-class-with-protected-method-from-trait' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithProtectedMethodFromTrait.php',
             'final-class-with-public-method' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/FinalClassWithPublicMethod.php',
         ];