From 6adf19c6bf490992e4750228b2d69fcf194b15b5 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20M=C3=B6ller?= Date: Sun, 10 May 2020 19:12:25 +0200 Subject: [PATCH] Fix: Rename data providers --- test/Integration/AbstractTestCase.php | 8 ++++---- test/Integration/Classes/FinalRuleTest.php | 4 ++-- .../Classes/FinalRuleWithAbstractClassesAllowedTest.php | 4 ++-- .../Classes/FinalRuleWithExcludedClassNamesTest.php | 4 ++-- test/Integration/Classes/NoExtendsRuleTest.php | 4 ++-- .../NoExtendsRuleWithClassesAllowedToBeExtendedTest.php | 4 ++-- .../Closures/NoNullableReturnTypeDeclarationRuleTest.php | 4 ++-- .../Closures/NoParameterWithNullDefaultValueRuleTest.php | 4 ++-- .../NoParameterWithNullableTypeDeclarationRuleTest.php | 4 ++-- test/Integration/Expressions/NoCompactRuleTest.php | 4 ++-- test/Integration/Expressions/NoEmptyRuleTest.php | 4 ++-- .../Expressions/NoErrorSuppressionRuleTest.php | 4 ++-- test/Integration/Expressions/NoEvalRuleTest.php | 4 ++-- test/Integration/Expressions/NoIssetRuleTest.php | 4 ++-- test/Integration/Files/DeclareStrictTypesRuleTest.php | 4 ++-- .../Functions/NoNullableReturnTypeDeclarationRuleTest.php | 4 ++-- .../Functions/NoParameterWithNullDefaultValueRuleTest.php | 4 ++-- .../NoParameterWithNullableTypeDeclarationRuleTest.php | 4 ++-- test/Integration/Methods/FinalInAbstractClassRuleTest.php | 4 ++-- .../NoConstructorParameterWithDefaultValueRuleTest.php | 4 ++-- .../Methods/NoNullableReturnTypeDeclarationRuleTest.php | 4 ++-- .../NoParameterWithContainerTypeDeclarationRuleTest.php | 4 ++-- .../Methods/NoParameterWithNullDefaultValueRuleTest.php | 4 ++-- .../NoParameterWithNullableTypeDeclarationRuleTest.php | 4 ++-- test/Integration/Methods/PrivateInFinalClassRuleTest.php | 4 ++-- test/Integration/Statements/NoSwitchRuleTest.php | 4 ++-- 26 files changed, 54 insertions(+), 54 deletions(-) diff --git a/test/Integration/AbstractTestCase.php b/test/Integration/AbstractTestCase.php index 69d073ed..ccecf400 100644 --- a/test/Integration/AbstractTestCase.php +++ b/test/Integration/AbstractTestCase.php @@ -21,7 +21,7 @@ abstract class AbstractTestCase extends RuleTestCase { /** - * @dataProvider providerAnalysisSucceeds + * @dataProvider provideCasesWhereAnalysisShouldSucceed * * @param string $path */ @@ -36,7 +36,7 @@ final public function testAnalysisSucceeds(string $path): void } /** - * @dataProvider providerAnalysisFails + * @dataProvider provideCasesWhereAnalysisShouldFail * * @param string $path * @param array $error @@ -53,7 +53,7 @@ final public function testAnalysisFails(string $path, array $error): void ); } - abstract public function providerAnalysisSucceeds(): iterable; + abstract public function provideCasesWhereAnalysisShouldSucceed(): iterable; - abstract public function providerAnalysisFails(): iterable; + abstract public function provideCasesWhereAnalysisShouldFail(): iterable; } diff --git a/test/Integration/Classes/FinalRuleTest.php b/test/Integration/Classes/FinalRuleTest.php index 1bf16ffa..1f197c61 100644 --- a/test/Integration/Classes/FinalRuleTest.php +++ b/test/Integration/Classes/FinalRuleTest.php @@ -25,7 +25,7 @@ */ final class FinalRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'final-class' => __DIR__ . '/../../Fixture/Classes/FinalRule/Success/FinalClass.php', @@ -49,7 +49,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'abstract-class' => [ diff --git a/test/Integration/Classes/FinalRuleWithAbstractClassesAllowedTest.php b/test/Integration/Classes/FinalRuleWithAbstractClassesAllowedTest.php index 701680dc..750e3705 100644 --- a/test/Integration/Classes/FinalRuleWithAbstractClassesAllowedTest.php +++ b/test/Integration/Classes/FinalRuleWithAbstractClassesAllowedTest.php @@ -25,7 +25,7 @@ */ final class FinalRuleWithAbstractClassesAllowedTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'abstract-class' => __DIR__ . '/../../Fixture/Classes/FinalRuleWithAbstractClassesAllowed/Failure/AbstractClass.php', @@ -44,7 +44,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'neither-abstract-nor-final-class' => [ diff --git a/test/Integration/Classes/FinalRuleWithExcludedClassNamesTest.php b/test/Integration/Classes/FinalRuleWithExcludedClassNamesTest.php index 08586d17..90614265 100644 --- a/test/Integration/Classes/FinalRuleWithExcludedClassNamesTest.php +++ b/test/Integration/Classes/FinalRuleWithExcludedClassNamesTest.php @@ -25,7 +25,7 @@ */ final class FinalRuleWithExcludedClassNamesTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'class-neither-abstract-nor-final-but-whitelisted' => __DIR__ . '/../../Fixture/Classes/FinalRuleWithExcludedClassNames/Success/NeitherAbstractNorFinalClassButWhitelisted.php', @@ -44,7 +44,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'abstract-class' => [ diff --git a/test/Integration/Classes/NoExtendsRuleTest.php b/test/Integration/Classes/NoExtendsRuleTest.php index 16c7cfe8..527c375f 100644 --- a/test/Integration/Classes/NoExtendsRuleTest.php +++ b/test/Integration/Classes/NoExtendsRuleTest.php @@ -25,7 +25,7 @@ */ final class NoExtendsRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'class' => __DIR__ . '/../../Fixture/Classes/NoExtendsRule/Success/ExampleClass.php', @@ -42,7 +42,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'class-extending-other-class' => [ diff --git a/test/Integration/Classes/NoExtendsRuleWithClassesAllowedToBeExtendedTest.php b/test/Integration/Classes/NoExtendsRuleWithClassesAllowedToBeExtendedTest.php index 95fccfcd..8f3cc6f1 100644 --- a/test/Integration/Classes/NoExtendsRuleWithClassesAllowedToBeExtendedTest.php +++ b/test/Integration/Classes/NoExtendsRuleWithClassesAllowedToBeExtendedTest.php @@ -25,7 +25,7 @@ */ final class NoExtendsRuleWithClassesAllowedToBeExtendedTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'class' => __DIR__ . '/../../Fixture/Classes/NoExtendsRuleWithClassesAllowedToBeExtended/Success/ExampleClass.php', @@ -44,7 +44,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'class-extending-other-class' => [ diff --git a/test/Integration/Closures/NoNullableReturnTypeDeclarationRuleTest.php b/test/Integration/Closures/NoNullableReturnTypeDeclarationRuleTest.php index acbc803a..92fe728b 100644 --- a/test/Integration/Closures/NoNullableReturnTypeDeclarationRuleTest.php +++ b/test/Integration/Closures/NoNullableReturnTypeDeclarationRuleTest.php @@ -24,7 +24,7 @@ */ final class NoNullableReturnTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'closure-with-return-type-declaration' => __DIR__ . '/../../Fixture/Closures/NoNullableReturnTypeDeclarationRule/Success/closure-with-return-type-declaration.php', @@ -38,7 +38,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'closure-with-nullable-return-type-declaration' => [ diff --git a/test/Integration/Closures/NoParameterWithNullDefaultValueRuleTest.php b/test/Integration/Closures/NoParameterWithNullDefaultValueRuleTest.php index 71a33a3c..c0de9ca1 100644 --- a/test/Integration/Closures/NoParameterWithNullDefaultValueRuleTest.php +++ b/test/Integration/Closures/NoParameterWithNullDefaultValueRuleTest.php @@ -24,7 +24,7 @@ */ final class NoParameterWithNullDefaultValueRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'closure-with-parameter-with-non-null-default-value' => __DIR__ . '/../../Fixture/Closures/NoParameterWithNullDefaultValueRule/Success/closure-with-parameter-with-non-null-default-value.php', @@ -39,7 +39,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'closure-with-parameter-with-null-default-value' => [ diff --git a/test/Integration/Closures/NoParameterWithNullableTypeDeclarationRuleTest.php b/test/Integration/Closures/NoParameterWithNullableTypeDeclarationRuleTest.php index c527edcb..13aac582 100644 --- a/test/Integration/Closures/NoParameterWithNullableTypeDeclarationRuleTest.php +++ b/test/Integration/Closures/NoParameterWithNullableTypeDeclarationRuleTest.php @@ -24,7 +24,7 @@ */ final class NoParameterWithNullableTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'closure-with-parameter-with-type-declaration' => __DIR__ . '/../../Fixture/Closures/NoParameterWithNullableTypeDeclarationRule/Success/closure-with-parameter-with-type-declaration.php', @@ -39,7 +39,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'closure-with-parameter-with-nullable-type-declaration' => [ diff --git a/test/Integration/Expressions/NoCompactRuleTest.php b/test/Integration/Expressions/NoCompactRuleTest.php index 7361ad9d..9fded84a 100644 --- a/test/Integration/Expressions/NoCompactRuleTest.php +++ b/test/Integration/Expressions/NoCompactRuleTest.php @@ -24,7 +24,7 @@ */ final class NoCompactRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'compact-not-used' => __DIR__ . '/../../Fixture/Expressions/NoCompactRule/Success/compact-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'compact-used-with-alias' => [ diff --git a/test/Integration/Expressions/NoEmptyRuleTest.php b/test/Integration/Expressions/NoEmptyRuleTest.php index 8f8534f6..3b776715 100644 --- a/test/Integration/Expressions/NoEmptyRuleTest.php +++ b/test/Integration/Expressions/NoEmptyRuleTest.php @@ -24,7 +24,7 @@ */ final class NoEmptyRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'empty-not-used' => __DIR__ . '/../../Fixture/Expressions/NoEmptyRule/Success/empty-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'empty-used-with-correct-case' => [ diff --git a/test/Integration/Expressions/NoErrorSuppressionRuleTest.php b/test/Integration/Expressions/NoErrorSuppressionRuleTest.php index 286f5ba5..fc03209a 100644 --- a/test/Integration/Expressions/NoErrorSuppressionRuleTest.php +++ b/test/Integration/Expressions/NoErrorSuppressionRuleTest.php @@ -24,7 +24,7 @@ */ final class NoErrorSuppressionRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'error-suppression-not-used' => __DIR__ . '/../../Fixture/Expressions/NoErrorSuppressionRule/Success/error-suppression-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'error-suppression-used' => [ diff --git a/test/Integration/Expressions/NoEvalRuleTest.php b/test/Integration/Expressions/NoEvalRuleTest.php index 9c1844cc..a1bd3e7b 100644 --- a/test/Integration/Expressions/NoEvalRuleTest.php +++ b/test/Integration/Expressions/NoEvalRuleTest.php @@ -24,7 +24,7 @@ */ final class NoEvalRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'eval-not-used' => __DIR__ . '/../../Fixture/Expressions/NoEvalRule/Success/eval-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'eval-used-with-correct-case' => [ diff --git a/test/Integration/Expressions/NoIssetRuleTest.php b/test/Integration/Expressions/NoIssetRuleTest.php index 1a755158..db444309 100644 --- a/test/Integration/Expressions/NoIssetRuleTest.php +++ b/test/Integration/Expressions/NoIssetRuleTest.php @@ -24,7 +24,7 @@ */ final class NoIssetRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'isset-not-used' => __DIR__ . '/../../Fixture/Expressions/NoIssetRule/Success/isset-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'isset-used-with-correct-case' => [ diff --git a/test/Integration/Files/DeclareStrictTypesRuleTest.php b/test/Integration/Files/DeclareStrictTypesRuleTest.php index a8fd8e2c..32a82a51 100644 --- a/test/Integration/Files/DeclareStrictTypesRuleTest.php +++ b/test/Integration/Files/DeclareStrictTypesRuleTest.php @@ -24,7 +24,7 @@ */ final class DeclareStrictTypesRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'file-empty' => __DIR__ . '/../../Fixture/Files/DeclareStrictTypesRule/Success/file-empty.php', @@ -50,7 +50,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'file-with-comment-and-declare-strict-types-off' => [ diff --git a/test/Integration/Functions/NoNullableReturnTypeDeclarationRuleTest.php b/test/Integration/Functions/NoNullableReturnTypeDeclarationRuleTest.php index 16b75d9a..c0028720 100644 --- a/test/Integration/Functions/NoNullableReturnTypeDeclarationRuleTest.php +++ b/test/Integration/Functions/NoNullableReturnTypeDeclarationRuleTest.php @@ -24,7 +24,7 @@ */ final class NoNullableReturnTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'function-with-return-type-declaration' => __DIR__ . '/../../Fixture/Functions/NoNullableReturnTypeDeclarationRule/Success/function-with-return-type-declaration.php', @@ -38,7 +38,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'function-with-nullable-return-type-declaration' => [ diff --git a/test/Integration/Functions/NoParameterWithNullDefaultValueRuleTest.php b/test/Integration/Functions/NoParameterWithNullDefaultValueRuleTest.php index a41fdd46..88923e36 100644 --- a/test/Integration/Functions/NoParameterWithNullDefaultValueRuleTest.php +++ b/test/Integration/Functions/NoParameterWithNullDefaultValueRuleTest.php @@ -24,7 +24,7 @@ */ final class NoParameterWithNullDefaultValueRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'function-with-parameter-with-non-null-default-value' => __DIR__ . '/../../Fixture/Functions/NoParameterWithNullDefaultValueRule/Success/function-with-parameter-with-non-null-default-value.php', @@ -39,7 +39,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'function-with-parameter-with-null-default-value' => [ diff --git a/test/Integration/Functions/NoParameterWithNullableTypeDeclarationRuleTest.php b/test/Integration/Functions/NoParameterWithNullableTypeDeclarationRuleTest.php index a11b86b4..f7e3a200 100644 --- a/test/Integration/Functions/NoParameterWithNullableTypeDeclarationRuleTest.php +++ b/test/Integration/Functions/NoParameterWithNullableTypeDeclarationRuleTest.php @@ -24,7 +24,7 @@ */ final class NoParameterWithNullableTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'function-with-parameter-with-type-declaration' => __DIR__ . '/../../Fixture/Functions/NoParameterWithNullableTypeDeclarationRule/Success/function-with-parameter-with-type-declaration.php', @@ -39,7 +39,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'function-with-parameter-with-nullable-type-declaration' => [ diff --git a/test/Integration/Methods/FinalInAbstractClassRuleTest.php b/test/Integration/Methods/FinalInAbstractClassRuleTest.php index 02fa1ff7..8c5d9d3e 100644 --- a/test/Integration/Methods/FinalInAbstractClassRuleTest.php +++ b/test/Integration/Methods/FinalInAbstractClassRuleTest.php @@ -25,7 +25,7 @@ */ final class FinalInAbstractClassRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'abstract-class-with-abstract-method' => __DIR__ . '/../../Fixture/Methods/FinalInAbstractClassRule/Success/AbstractClassWithAbstractMethod.php', @@ -42,7 +42,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'abstract-class-with-protected-method' => [ diff --git a/test/Integration/Methods/NoConstructorParameterWithDefaultValueRuleTest.php b/test/Integration/Methods/NoConstructorParameterWithDefaultValueRuleTest.php index f69427a8..56e8bcc0 100644 --- a/test/Integration/Methods/NoConstructorParameterWithDefaultValueRuleTest.php +++ b/test/Integration/Methods/NoConstructorParameterWithDefaultValueRuleTest.php @@ -25,7 +25,7 @@ */ final class NoConstructorParameterWithDefaultValueRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'constructor-in-anonymous-class-with-parameter-without-default-value' => __DIR__ . '/../../Fixture/Methods/NoConstructorParameterWithDefaultValueRule/Success/constructor-in-anonymous-class-with-parameter-without-default-value.php', @@ -49,7 +49,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'constructor-in-anonymous-class-with-parameter-with-default-value' => [ diff --git a/test/Integration/Methods/NoNullableReturnTypeDeclarationRuleTest.php b/test/Integration/Methods/NoNullableReturnTypeDeclarationRuleTest.php index e543eefb..05aa287e 100644 --- a/test/Integration/Methods/NoNullableReturnTypeDeclarationRuleTest.php +++ b/test/Integration/Methods/NoNullableReturnTypeDeclarationRuleTest.php @@ -25,7 +25,7 @@ */ final class NoNullableReturnTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'method-in-anonymous-class-with-return-type-declaration' => __DIR__ . '/../../Fixture/Methods/NoNullableReturnTypeDeclarationRule/Success/MethodInAnonymousClassWithReturnTypeDeclaration.php', @@ -47,7 +47,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'method-in-anonymous-class-with-nullable-return-type-declaration' => [ diff --git a/test/Integration/Methods/NoParameterWithContainerTypeDeclarationRuleTest.php b/test/Integration/Methods/NoParameterWithContainerTypeDeclarationRuleTest.php index 06c0e746..6c282d9e 100644 --- a/test/Integration/Methods/NoParameterWithContainerTypeDeclarationRuleTest.php +++ b/test/Integration/Methods/NoParameterWithContainerTypeDeclarationRuleTest.php @@ -27,7 +27,7 @@ */ final class NoParameterWithContainerTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'anonymous-class-with-method-with-parameter-with-other-type-declaration' => __DIR__ . '/../../Fixture/Methods/NoParameterWithContainerTypeDeclarationRule/Success/anonymous-class-with-method-with-parameter-with-other-type-declaration.php', @@ -45,7 +45,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'anonymous-class-with-method-with-parameter-with-class-implementing-container-interface-as-type-declaration' => [ diff --git a/test/Integration/Methods/NoParameterWithNullDefaultValueRuleTest.php b/test/Integration/Methods/NoParameterWithNullDefaultValueRuleTest.php index b04200f4..da9a1205 100644 --- a/test/Integration/Methods/NoParameterWithNullDefaultValueRuleTest.php +++ b/test/Integration/Methods/NoParameterWithNullDefaultValueRuleTest.php @@ -25,7 +25,7 @@ */ final class NoParameterWithNullDefaultValueRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'method-in-anonymous-class-with-parameter-with-non-null-default-value' => __DIR__ . '/../../Fixture/Methods/NoParameterWithNullDefaultValueRule/Success/method-in-anonymous-class-with-parameter-with-non-null-default-value.php', @@ -53,7 +53,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'method-in-anonymous-class-with-parameter-with-null-default-value' => [ diff --git a/test/Integration/Methods/NoParameterWithNullableTypeDeclarationRuleTest.php b/test/Integration/Methods/NoParameterWithNullableTypeDeclarationRuleTest.php index 77488355..65df833b 100644 --- a/test/Integration/Methods/NoParameterWithNullableTypeDeclarationRuleTest.php +++ b/test/Integration/Methods/NoParameterWithNullableTypeDeclarationRuleTest.php @@ -25,7 +25,7 @@ */ final class NoParameterWithNullableTypeDeclarationRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'method-in-anonymous-class-with-parameter-with-type-declaration' => __DIR__ . '/../../Fixture/Methods/NoParameterWithNullableTypeDeclarationRule/Success/method-in-anonymous-class-with-parameter-with-type-declaration.php', @@ -50,7 +50,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'method-in-anonymous-class-with-parameter-with-nullable-type-declaration' => [ diff --git a/test/Integration/Methods/PrivateInFinalClassRuleTest.php b/test/Integration/Methods/PrivateInFinalClassRuleTest.php index 2f2b16f1..444cbcde 100644 --- a/test/Integration/Methods/PrivateInFinalClassRuleTest.php +++ b/test/Integration/Methods/PrivateInFinalClassRuleTest.php @@ -25,7 +25,7 @@ */ final class PrivateInFinalClassRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'abstract-class-with-protected-method' => __DIR__ . '/../../Fixture/Methods/PrivateInFinalClassRule/Success/AbstractClassWithProtectedMethod.php', @@ -43,7 +43,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'final-class-with-protected-method' => [ diff --git a/test/Integration/Statements/NoSwitchRuleTest.php b/test/Integration/Statements/NoSwitchRuleTest.php index 0abee3d1..e4577ce8 100644 --- a/test/Integration/Statements/NoSwitchRuleTest.php +++ b/test/Integration/Statements/NoSwitchRuleTest.php @@ -24,7 +24,7 @@ */ final class NoSwitchRuleTest extends AbstractTestCase { - public function providerAnalysisSucceeds(): iterable + public function provideCasesWhereAnalysisShouldSucceed(): iterable { $paths = [ 'isset-not-used' => __DIR__ . '/../../Fixture/Statements/NoSwitchRule/Success/switch-not-used.php', @@ -37,7 +37,7 @@ public function providerAnalysisSucceeds(): iterable } } - public function providerAnalysisFails(): iterable + public function provideCasesWhereAnalysisShouldFail(): iterable { $paths = [ 'switch-used-with-correct-case' => [