From fc825f674cb57e3198576bd9c2abbc4ac6595c8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20M=C3=B6ller?= Date: Thu, 2 May 2019 13:56:15 +0200 Subject: [PATCH 1/2] Fix: Enable Expressions\NoIssetRule --- CHANGELOG.md | 10 +++++++++- rules.neon | 1 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9bb94784..212fd29d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,7 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), ## Unreleased -For a full diff see [`0.8.0...master`](https://github.com/localheinz/phpstan-rules/compare/0.8.0...master). +For a full diff see [`0.8.1...master`](https://github.com/localheinz/phpstan-rules/compare/0.8.1...master). + +## [`0.8.1`](https://github.com/localheinz/phpstan-rules/releases/tag/0.8.1) + +For a full diff see [`0.8.0...0.8.1`](https://github.com/localheinz/phpstan-rules/compare/0.8.0...0.8.1). + +### Fixed + +* Actually enable `Expressions\NoIssetRule` ([#83](https://github.com/localheinz/phpstan-rules/pull/83)), by [@localheinz](https://github.com/localheinz) ## [`0.8.0`](https://github.com/localheinz/phpstan-rules/releases/tag/0.8.0) diff --git a/rules.neon b/rules.neon index a290a2d7..9dc14e09 100644 --- a/rules.neon +++ b/rules.neon @@ -6,6 +6,7 @@ parameters: rules: - Localheinz\PHPStan\Rules\Closures\NoNullableReturnTypeDeclarationRule - Localheinz\PHPStan\Rules\Closures\NoParameterWithNullableTypeDeclarationRule + - Localheinz\PHPStan\Rules\Expressions\NoIssetRule - Localheinz\PHPStan\Rules\Functions\NoNullableReturnTypeDeclarationRule - Localheinz\PHPStan\Rules\Functions\NoParameterWithNullableTypeDeclarationRule - Localheinz\PHPStan\Rules\Functions\NoParameterWithNullDefaultValueRule From 79794115f80535591c24d40e0ba057120ed5c00a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20M=C3=B6ller?= Date: Thu, 2 May 2019 14:30:22 +0200 Subject: [PATCH 2/2] Fix: Ignore errors --- phpstan.neon | 2 ++ 1 file changed, 2 insertions(+) diff --git a/phpstan.neon b/phpstan.neon index 2a29e855..ef921164 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -10,6 +10,8 @@ parameters: - PHPStan\Testing\RuleTestCase excludes_analyse: - %currentWorkingDirectory%/test/Fixture/ + ignoreErrors: + - '#Language construct isset\(\) should not be used.#' paths: - src - test