-
Notifications
You must be signed in to change notification settings - Fork 210
An invite exemption is NOT a ban exemption. #1874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should require no further explanation.
|
Invites usually override bans. And invite exceptions are treated like a permanent invite, so this doesn't seem wrong to me. |
Seriously!? I mean, I guess I'll double check the RFC(s). |
|
I may be wrong, but the current behavior is not completely nonsensical either. |
https://datatracker.ietf.org/doc/html/rfc1459#section-4.2.1 RFC 1459 - Internet Relay Chat Protocol - May 1993furthermoreThat's literally what +e is for. +I is not +e. |
|
I'm willing to reconsider this, but it is not a straightforward decision at all, particularly considering that it is a compatibility break that will result in people becoming newly unable to join channels. Keep in mind that the RFCs are not necessarily authoritative on this issue (or any other, really); that's what modern.ircdocs.horse is for. It sounds like you are experiencing a problem with the current behavior in your deployment? What is the problem specifically? |
|
Looking at the code, it doesn't seem like INVITEs override bans in Ergo, so there's indeed an inconsistency here, but it does not seem to be such a big deal. I agree with slingamn this deserves to be discussed. |
|
INVITE was intended to override +b (and did so in v2.2 and v2.3), but does not due to a regression introduced in v2.4. I have filed a separate issue for this as #1876. The issue in this PR (whether +I should override +b) was discussed previously in connection with #1168, and the outcome was that it should, so the current behavior is intentional (although it can still be reconsidered, of course). But in the absence of a specific reason to change the behavior, the current behavior will probably stand. |
|
What about the potential for ban evading? If I were able to get a bot +o in a channel where i was +b previously, i could technically avoid being banned if that was overridden by an invite every time. |
|
I agree with /invite overriding channel bans and all other restrictions. Invites can only be done by channel ops (or higher) which is the same level of moderation that adds channel bans. I don't see what would be the gain of making this change, except perhaps to protect the chanop from themselves, so to speak. |
You could just have the bot remove the ban, right? |
Yeah, you're right. I for a moment thought that halfop could invite but I just verified this is not the case. However you're right, the other circumstances of having a bot or alternate client in the channel as an operator has no weight on either direction of functionality. My mistake. |
aight denexplain why +e exists. |
|
Here's where we're at in this discussion: on other ircds, The question "what is |
|
I'm alright with this being resolved either way, no stress. We don't pay too much mind to the RFCs, but if this is causing a usability issue then definitely let us know. |
This should require no further explanation.