Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py does not require flask #2

Open
dgabbe opened this issue Sep 10, 2019 · 10 comments
Open

setup.py does not require flask #2

dgabbe opened this issue Sep 10, 2019 · 10 comments

Comments

@dgabbe
Copy link
Contributor

@dgabbe dgabbe commented Sep 10, 2019

Setup.py is missing a stanza to require flask.

@dgabbe

This comment has been minimized.

Copy link
Contributor Author

@dgabbe dgabbe commented Sep 10, 2019

Travis works because it installs modules listed in requirements.txt.

@eric-s-s eric-s-s added the bug label Sep 22, 2019
@eric-s-s

This comment has been minimized.

Copy link
Owner

@eric-s-s eric-s-s commented Sep 22, 2019

as an additional fix, first remove the install of requirements.txt from the .travis.yaml and watch the build fail. then fix

@ragnarokatz

This comment has been minimized.

Copy link

@ragnarokatz ragnarokatz commented Oct 7, 2019

@eric-s-s hello, I would like to give this issue a try please.

@ragnarokatz

This comment has been minimized.

Copy link

@ragnarokatz ragnarokatz commented Oct 7, 2019

reference pull request #7

@eric-s-s

This comment has been minimized.

Copy link
Owner

@eric-s-s eric-s-s commented Oct 7, 2019

@ragnarokatz Excellent and welcome!

@eric-s-s

This comment has been minimized.

Copy link
Owner

@eric-s-s eric-s-s commented Oct 7, 2019

as you'll note in the conversation above, first I want to make sure that the travis build will properly fail without the install_requires field. This means first editing the .travis.yaml file so that it doesn't install requirements.txt. Once that build fails, then add the install requires lines and (hopefully) watch it pass on the next build.

@ragnarokatz

This comment has been minimized.

Copy link

@ragnarokatz ragnarokatz commented Oct 9, 2019

hello @eric-s-s, I have removed both the install_requires field from setup.py, as well as removed the pip install -r requirements.txt line from .travis.yaml. as a result, all checks have failed.

image

image

now I will proceed to add back the install_requires field to setup.py file and hopefully all checks will pass.

@ragnarokatz

This comment has been minimized.

Copy link

@ragnarokatz ragnarokatz commented Oct 9, 2019

nope, still fails:

image

@eric-s-s
should I add the pip install -r requirements.txt line back in? or do you prefer a different solution?

@eric-s-s

This comment has been minimized.

Copy link
Owner

@eric-s-s eric-s-s commented Oct 9, 2019

definitely a different solution. if you look at the build report, everything loaded fine, and there's some other problem.

@dgabbe

This comment has been minimized.

Copy link
Contributor Author

@dgabbe dgabbe commented Nov 7, 2019

Eric,

Something to try as I think you mentioned it was a breaking change to Flask is to add a constraints.txt to the project to control which version requirements.txt will install if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.