Cleaned up selection of librato metics #19

Open
wants to merge 4 commits into from

4 participants

@JustinLove

I took Ryanlower's selection code, (eric/metriks#9) made the necessary checks for empty filters, and added a few tests to cover the new cases. Did a very simple extract-method to support the tests.

@eric
Owner

This looks pretty sweet. Thanks!

@beanieboi

hey,

what happened to the pull request? just read through the related issues and couldn't find a hint why this isn't merged yet.

how can i help to get this merged?

@eric
Owner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment