Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fix for issue #161 #162

Merged
merged 3 commits into from

2 participants

djessup Eric M. Suzanne
djessup

Added setting to allow the prefix used for IE6/7 propery hacks to be
customised.

See: #161

djessup added some commits
djessup djessup Added $ie-property-hack-prefix option
Added setting to allow the prefix used for IE6/7 propery hacks to be
customised.
0381086
djessup djessup Documentation for $ie-property-hack-prefix 63dbe49
Eric M. Suzanne
Owner

I don't see ay reason to add a setting for a hack. If there's a better hack to be using for the same purpose, I'd rather just make the change and move on. There's nothing special about the specific hack. Can you re-submit without the setting?

djessup djessup Removed $ie-property-hack-fix
Reverted to a hard-coded IE6/7 hack prefix, but now using a start-hack
instead of bang-hack.
dcd3daa
djessup

No problem, I figured there might have been some preference for some to use the bang-hack, but if you're happy to use a star hack instead then great!

I've committed a revision which removes the setting and hard-codes the star-hack style instead.

Eric M. Suzanne ericam merged commit 0c11935 into from
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 21, 2013
  1. djessup

    Added $ie-property-hack-prefix option

    djessup authored
    Added setting to allow the prefix used for IE6/7 propery hacks to be
    customised.
  2. djessup
Commits on Feb 27, 2013
  1. djessup

    Removed $ie-property-hack-fix

    djessup authored
    Reverted to a hard-coded IE6/7 hack prefix, but now using a start-hack
    instead of bang-hack.
This page is out of date. Refresh to see the latest.
Showing with 5 additions and 5 deletions.
  1. +1 −1  docs/Gemfile.lock
  2. +3 −3 sass/susy/_grid.scss
  3. +1 −1  susy.gemspec
2  docs/Gemfile.lock
View
@@ -19,7 +19,7 @@ GIT
PATH
remote: ../
specs:
- susy (1.0.static.5)
+ susy (1.0.5)
compass (>= 0.12.2)
sass (>= 3.2.0)
6 sass/susy/_grid.scss
View
@@ -163,7 +163,7 @@
margin-#{$to}: 0;
@if $legacy-support-for-ie6 or $legacy-support-for-ie7 {
- #margin-#{$hack}: - $gutter-width;
+ *margin-#{$hack}: - $gutter-width;
@if $legacy-support-for-ie6 { display: inline; }
}
}
@@ -203,7 +203,7 @@
margin-#{$to}: auto;
@if $legacy-support-for-ie6 or $legacy-support-for-ie7 {
- #margin-#{$hack}: auto;
+ *margin-#{$hack}: auto;
@if $legacy-support-for-ie6 { display: block; }
}
}
@@ -227,7 +227,7 @@
margin-#{$to}: gutter($context, $style);
@if $legacy-support-for-ie6 or $legacy-support-for-ie7 {
- #margin-#{$hack}: auto;
+ *margin-#{$hack}: auto;
}
}
2  susy.gemspec
View
@@ -6,7 +6,7 @@ Gem::Specification.new do |s|
s.required_rubygems_version = Gem::Requirement.new(">= 1.2") if s.respond_to? :required_rubygems_version=
s.authors = ["Eric Meyer"]
- s.date = "2012-12-02"
+ s.date = "2013-02-21"
s.description = "Susy grids are fluid on the inside, ready to respond at any moment, but contained in the candy shell of your choice, so they respond how and when and where you want them to. We don't design your site or dictate your markup, we just do the math and get out of your way."
s.email = "eric@oddbird.net"
s.extra_rdoc_files = ["CHANGELOG.mkdn", "LICENSE.txt", "README.md", "lib/susy.rb"]
Something went wrong with that request. Please try again.