Add breakpoint
value to settings maps, add simple-susy-breakpoint mixin
#397
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are my thoughts behind this: I'd like to attach breakpoint MQ-data directly to a settings map (yep, that means a tighter integration with Breakpoint). I'd also like to shorten the syntax for generating new grid styles in a new breakpoint context. Rather than:
I'd prefer:
In the request I've submitted, the
$config
settings map will have abreakpoint
key that would hold a value/list that's compatible with Breakpoint. The mixin would get that value automatically (I use a settings map per breakpoint if the column count or proportions change responsively), then get either a span value (span, location, layout) or the wordcontainer
and callspan()
orcontainer()
from$columns
. If it's a container, the$grid
parameter would tell the mixin to re-runshow-grids()
at this breakpoint.Not sold on the name at all - please suggest a better one (or we could work to add this functionality to
susy-breakpoint()
while maintaining backwards-compatibility.Thanks!