Eric Bottard ericbottard

Organizations

@spring-projects @cloudfoundry-samples
ericbottard commented on pull request spring-projects/spring-xd#1516
@ericbottard

Addressed all issues

@ericbottard
ericbottard commented on pull request spring-projects/spring-xd#1516
@ericbottard

In the process of doing that. Realized that I forgot to move ModuleOptionsReferenceDoc out of shell. Will ping you once this PR is updated correctly

@ericbottard
  • @ericbottard f65214a
    Address minor review comments
@ericbottard

I'm not sure this is better. This still creates a definition that is half-complete. How long is this piece of code going to stay in the codebase (i…

@ericbottard
XD-2860: Move dummy MD to tests only
1 commit with 132 additions and 103 deletions
ericbottard commented on pull request spring-projects/spring-xd#1516
@ericbottard

Yes, this has always been like so. Avoids scanning all asciidoc files

ericbottard commented on pull request spring-projects/spring-xd#1516
@ericbottard

yes :)

@ericbottard
XD-2834: generate docs as part of "standard" build
3 commits with 321 additions and 288 deletions
ericbottard commented on pull request spring-projects/spring-xd#1515
@ericbottard

-1, see my comment

ericbottard commented on pull request spring-projects/spring-xd#1515
@ericbottard

Please don't use ModuleDefinitions.dummy() If there really is a migration issue, then recreate the correct definitions (or tell the users to manual…

ericbottard opened pull request ghillert/spring-xd#3
@ericbottard
Ghillert xd 2830
5 commits with 1,938 additions and 763 deletions
@ericbottard

LGTM, thanks for polishing even further. Shiny!

@ericbottard
[Sprint 45] XD-2837 Admin scripts to include hadoop classpath
ericbottard commented on pull request spring-projects/spring-xd#1511
@ericbottard

Merged as 47fa882

@ericbottard
  • @ilayaperumalg 47fa882
    XD-2837 Admin scripts to include hadoop classpath
ericbottard commented on pull request spring-projects/spring-xd#1511
@ericbottard

This works (tested the *nix version) and allows one to successfully upload a module to HDFS with xd-admin. However, The admin does not need full "…

@ericbottard
@ericbottard
@ericbottard
ericbottard commented on pull request spring-projects/spring-xd#1509
@ericbottard

Actually, I'm applying it to this PR to avoid pollRate going in the wild

ericbottard commented on pull request spring-projects/spring-xd#1509
@ericbottard

I created https://jira.spring.io/browse/XD-2846 to track the initialDelay thing, as there are several modules that could benefit from this. I sugge…

ericbottard commented on pull request spring-projects/spring-xd#1509
@ericbottard

Indeed. Will do.

@ericbottard