Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for #53 #54

Merged
merged 6 commits into from
Apr 22, 2014
Merged

Fix for #53 #54

merged 6 commits into from
Apr 22, 2014

Conversation

paulpflug
Copy link
Collaborator

Fix for #53

@paulpflug
coffee spawns own, uncontrollable child process
8e21fdd 
when using coffee as cmd the server is not restartable
workaround by using node with local coffe-script instead
@paulpflug
Added cmdArgs option
6d05d6f 
Changed behavior to only warn of coffee
Added cmdArgs option
@paulpflug
Fix for #53
1c6ae06 
finished function was called regardless of server state
@paulpflug
Revert "Added cmdArgs option"
dffeb20 
This reverts commit 6d05d6f.
@paulpflug
Revert "coffee spawns own, uncontrollable child process"
d64df4d 
This reverts commit 8e21fdd.
@paulpflug
bugfix
bd12675
@paulpflug paulpflug mentioned this pull request Apr 13, 2014
Merged
@paulpflug paulpflug mentioned this pull request Apr 20, 2014
Closed
ericclemmons added a commit that referenced this pull request Apr 22, 2014
@ericclemmons
Merge pull request #54 from paulpflug/fix-for-#53
42308cd 
Fix for #53
@ericclemmons ericclemmons merged commit 42308cd into ericclemmons:master Apr 22, 2014
@ericclemmons
Copy link
Owner

v0.4.14 contains this fix! Thank you for the help @paulpflug :)

@pedramphp
Copy link

amazing this is fixed, I tested it as well.

@paulpflug paulpflug deleted the fix-for-#53 branch April 22, 2014 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@paulpflug @ericclemmons @pedramphp