Handle transform errors with nice logging. #11

Merged
merged 1 commit into from Dec 2, 2013

Conversation

Projects
None yet
2 participants
Contributor

steida commented Nov 12, 2013

Try catch is must to not break Grunt watchers.

Owner

ericclemmons commented Nov 12, 2013

This still causes a DING in the console, right? That was one problem I've had with other tools that, during watch, would fail silently and the remaining tasks kept running.

Contributor

steida commented Nov 12, 2013

No DING. But also don't break watching, which is more important then DING. I used error code from https://github.com/gruntjs/grunt-contrib-coffee

Owner

ericclemmons commented Nov 12, 2013

I'll have to double-check this, then. My react + grunt projects compile with browserify, then depends on that output for remaining build tasks.

Regarding importance, returning a proper error/success status from a script takes the cake, but that doesn't prevent this becoming a quiet or silent option!

See this similar thread: karma-runner/grunt-karma#39

Contributor

steida commented Nov 15, 2013

In the other words, with my watcher it's beeping.

Contributor

steida commented Nov 17, 2013

Never mind, I created own Grunt plugin https://github.com/steida/grunt-reactjsx. It leverages Grunt file api better and don't break file watchers.

steida closed this Nov 17, 2013

ericclemmons reopened this Nov 17, 2013

ericclemmons merged commit 0941c2d into ericclemmons:master Dec 2, 2013

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment