update react-tools to ~0.4.0 #3

Merged
merged 1 commit into from Jul 31, 2013

Conversation

Projects
None yet
2 participants
Contributor

hmil commented Jul 30, 2013

This uses the latest react-tools version.
Currently, using grunt-react with react lib v0.4.0 in the browser prints warning messages and prevents internal optimizations.
Tests passes, this is not a major version, it shouldn't break...

Owner

ericclemmons commented Jul 30, 2013

React just updated to 0.4.1. Should we use that version instead?

Contributor

hmil commented Jul 31, 2013

It's tilde version range so if you try now, you get 0.4.1 and this should work until next minor (see https://npmjs.org/doc/json.html#Tilde-Version-Ranges ). You could use 0.x since minor are not supposed to break either but it's a bit risky. Moreover, this allows you to bump grunt-react version number accordingly so we know that using grunt-react 0.4.x uses react-tools 0.4.x

Owner

ericclemmons commented Jul 31, 2013

Oh, that's right! I use them myself, but I still find myself of being in the habit of explicitly setting the version :)

Anyway, thanks for the PR. I'm merging down now!

ericclemmons added a commit that referenced this pull request Jul 31, 2013

Merge pull request #3 from Agent-H/v0.4
update react-tools to ~0.4.0

@ericclemmons ericclemmons merged commit 4a5f4a5 into ericclemmons:master Jul 31, 2013

1 check passed

default The Travis CI build passed
Details
Owner

ericclemmons commented Jul 31, 2013

Now at grunt-react@v0.4.0, just because I like both projects to be on 0.4.x :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment