Select boxes #2

Closed
ericclemmons opened this Issue Dec 18, 2012 · 4 comments

2 participants

@ericclemmons

When tracking change events on a <select />, it would be nice to indicate what the value is of the select.

@ericclemmons ericclemmons added a commit that closed this issue Mar 27, 2013
@ericclemmons Add support for <form> elements
Closes #2
45fe03f
@ronkorving

So why didn't you use :checked?
The problem with the current approach is that password values are put in a querySelector string. Are you sure this makes sense? (It definitely doesn't for my use cases). Perhaps it can be suppressed when the tagName is password?

@ericclemmons

Can you recreate this as an issue? The use-case was for tracking which item was selected, so you could copy-paste the selector in the same page yourself & re-produce what the user saw/clicked/etc.

The password example makes sense. I think there are different selectors that make sense for different tags.

@ronkorving

I can see where it makes sense. And a value is more readable than an nth-child. I'm just worried about those cases where value is user input (textarea, text, password, and all the new types like email, etc). I'll open an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment