Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping for Unix shells after whitespace with {interpolation:true} #324

Merged
merged 5 commits into from Jul 5, 2022

Conversation

ericcornelissen
Copy link
Owner

@ericcornelissen ericcornelissen commented Jul 5, 2022

Closes #323

Fuzzing for this requires #318, hence fuzzing will be taken care of after this is merged into main

Update the test fixtures (used for unit and integration tests) for
all shells on Unix to include exmaple where characters need to be
escaped because they appear after whitespace (thus far represented only
by a space character, ` `). Namely:

- `~` (for Bash, Dash, and Zsh)
- `#` (for Bash, Dash, and Zsh)
- `=` (for Zsh)
@ericcornelissen ericcornelissen added the bug Something isn't working label Jul 5, 2022
@ericcornelissen ericcornelissen added the pending This cannot be worked on yet label Jul 5, 2022
Based on locally run experiments. The script used for testing is based
on the interpolation recipe.
@ericcornelissen ericcornelissen changed the title Escaping for Unix shells after whitespace with {interpolation:true} Escaping for Unix shells after whitespace with {interpolation:true} Jul 5, 2022
@ericcornelissen ericcornelissen removed the pending This cannot be worked on yet label Jul 5, 2022
@ericcornelissen ericcornelissen merged commit 994af92 into main Jul 5, 2022
@ericcornelissen ericcornelissen deleted the bug-323/unix-escaping branch July 5, 2022 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing escaping for Unix shells for certain characters after whitespace with interpolation:true
1 participant