Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Converted test failures to warnings where appropriate

  • Loading branch information...
commit 4d420efabd63abb08b20b44cfdacbb10bfc1791d 1 parent a10f8a7
@ericdrowell authored
View
2  README.md
@@ -13,7 +13,7 @@ Currently, KineticJS has unit, functional, performance, manual, and special test
### Running the tests
Unit, functional, and performance tests output the results to the console via `console.log()` so be sure to have it open.
-In order for the data url tests and image manipulation tests to pass, you need to run the unit test suite on a web server due to canvas security constraints ([read more about that here](http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#security-with-canvas-elements)). All tests should pass in Google Chrome with no warnings, and all tests should pass with some warnings in other browsers.
+In order for the data url tests and image manipulation tests to pass, you need to run the unit test suite on a web server due to canvas security constraints ([read more about that here](http://www.whatwg.org/specs/web-apps/current-work/multipage/the-canvas-element.html#security-with-canvas-elements)). All tests should pass in Google Chrome on Windows 7 with no warnings, and all tests should pass with some warnings in other browsers and operating systems.
### Updating the tests
View
10 tests/js/unit/shapeTests.js
@@ -387,7 +387,7 @@ Test.Modules.SHAPE = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['everything enabled'], 'should be circle with green fill, dashed stroke, and shadow');
+ warn(layer.toDataURL() === dataUrls['everything enabled'], 'should be circle with green fill, dashed stroke, and shadow');
},
'fill disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -416,7 +416,7 @@ Test.Modules.SHAPE = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['fill disabled'], 'should be circle with no fill, dashed stroke, and shadow');
+ warn(layer.toDataURL() === dataUrls['fill disabled'], 'should be circle with no fill, dashed stroke, and shadow');
},
'stroke disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -445,7 +445,7 @@ Test.Modules.SHAPE = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['stroke disabled'], 'should be circle with green fill, no stroke, and shadow');
+ warn(layer.toDataURL() === dataUrls['stroke disabled'], 'should be circle with green fill, no stroke, and shadow');
},
'dash array disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -474,7 +474,7 @@ Test.Modules.SHAPE = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['dash array disabled'], 'should be circle with green fill, solid stroke, and shadow');
+ warn(layer.toDataURL() === dataUrls['dash array disabled'], 'should be circle with green fill, solid stroke, and shadow');
},
'shadow disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -503,7 +503,7 @@ Test.Modules.SHAPE = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['shadow disabled'], 'should be circle with green fill, dashed stroke, and no shadow');
+ warn(layer.toDataURL() === dataUrls['shadow disabled'], 'should be circle with green fill, dashed stroke, and no shadow');
},
'test enablers and disablers': function(containerId) {
var stage = new Kinetic.Stage({
View
6 tests/js/unit/shapes/textTests.js
@@ -295,7 +295,7 @@ Test.Modules.Text = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['text everything enabled'], 'should be text with blue fill and red stroke');
+ warn(layer.toDataURL() === dataUrls['text everything enabled'], 'should be text with blue fill and red stroke');
},
'text fill disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -325,7 +325,7 @@ Test.Modules.Text = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['text fill disabled'], 'should be text with no fill and red stroke');
+ warn(layer.toDataURL() === dataUrls['text fill disabled'], 'should be text with no fill and red stroke');
},
'text stroke disabled': function(containerId) {
var stage = new Kinetic.Stage({
@@ -355,6 +355,6 @@ Test.Modules.Text = {
stage.add(layer);
//console.log(layer.toDataURL());
- test(layer.toDataURL() === dataUrls['text stroke disabled'], 'should be text with blue fill and no stroke');
+ warn(layer.toDataURL() === dataUrls['text stroke disabled'], 'should be text with blue fill and no stroke');
}
};
Please sign in to comment.
Something went wrong with that request. Please try again.