Change container height to match content height on update #4

wants to merge 2 commits into


None yet

2 participants


Hi Eric,

Thank you for providing this plugin. I found I had to modify it locally a little bit to suit my scenario. My modal dialog loads content via AJAX based on certain user events. The returned data may cause the dialog's contents to grow beyond the height of the container. With autoResize the container would just start scrolling vertically (overflow:auto) instead of increasing its height (to min(max height, height of content)).

The change in my branch solves this problem for me, but I haven't had a chance to test it much and I haven't worked with your library for very long. Please let me know if there is a better way to solve this problem or if my fix isn't complete.


DashBDev commented Feb 6, 2012

This is something I would like to see in simplemodal too. I pop the modal before I have all the data so that the user can see something is happening, but then the size is stuck once I have the data. The below hack is the easiest way I've found to make it resize:

$("#simplemodal-container").css('height', 'auto');

Calling $.modal.update() by itself does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment