Skip to content
This repository

Change container height to match content height on update #4

Open
wants to merge 2 commits into from

2 participants

Dmitri Vassilenko DashBDev
Dmitri Vassilenko

Hi Eric,

Thank you for providing this plugin. I found I had to modify it locally a little bit to suit my scenario. My modal dialog loads content via AJAX based on certain user events. The returned data may cause the dialog's contents to grow beyond the height of the container. With autoResize the container would just start scrolling vertically (overflow:auto) instead of increasing its height (to min(max height, height of content)).

The change in my branch solves this problem for me, but I haven't had a chance to test it much and I haven't worked with your library for very long. Please let me know if there is a better way to solve this problem or if my fix isn't complete.

Thanks,
Dmitri

DashBDev

This is something I would like to see in simplemodal too. I pop the modal before I have all the data so that the user can see something is happening, but then the size is stuck once I have the data. The below hack is the easiest way I've found to make it resize:

$("#simplemodal-container").css('height', 'auto');
$.modal.update();

Calling $.modal.update() by itself does nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.

Showing 1 changed file with 1 addition and 0 deletions. Show diff stats Hide diff stats

  1. 1  src/jquery.simplemodal.js
1  src/jquery.simplemodal.js
@@ -549,6 +549,7 @@
549 549
 				}
550 550
 			}
551 551
 			else {
  552
+				ch = s.o.autoResize && dh ? dh : ch;
552 553
 				ch = s.o.autoResize && ch > mh ? mh : ch < moh ? moh : ch;
553 554
 			}
554 555
 
Commit_comment_tip

Tip: You can add notes to lines in a file. Hover to the left of a line to make a note

Something went wrong with that request. Please try again.