New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 Compliance: Add role attribute to modal. #70

Merged
merged 1 commit into from Nov 10, 2017

Conversation

Projects
None yet
2 participants
@santhoshbalakrishnan
Contributor

santhoshbalakrishnan commented Feb 27, 2017

Adding role="dialog" attribute to the simple modal container for screen readers to interpret the container div as a dialog modal.

Tested manually that the screen readers say 'dialog' when mouse enters or tabbed inside the modal.

508 Compliance: Add role attribute to modal.
Adding role="dialog" attribute to the simple modal container for screen readers to interpret the container div as a dialog modal.

Tested manually that the screen readers say 'dialog' when mouse enters or tabbed inside the modal.

@JohnSThomas JohnSThomas merged commit c284539 into ericmmartin:master Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment