@ericnormand
  • @ericnormand 8e28b0c
    Wed Jul 29 23:31:49 CDT 2015
@ericnormand
ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

We can make notes optional.

ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

db.fn/retractEntity retracts all datoms where the given id is in the entity position and all datoms where the id is in the value position. http://d…

ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

Ping @cap10morgan, thanks for reviewing. It's getting better.

@ericnormand
  • @ericnormand 6a9dcef
    [EN JE] Convert lists back into sets after mapping.
ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

I think we addressed everything. I made the note property common among everything. It's called :admin/note since they seemed to be used for the sam…

@ericnormand
  • @ericnormand ebcdeb4
    [EN JE] Use built-in retractEntity function instead of simply retract…
@ericnormand
  • @ericnormand 0546671
    [EN JE] Delete unused code
@ericnormand
  • @ericnormand aab1cb1
    [EN JE] Make voting-options and voter-registration-options sets inste…
@ericnormand
  • @ericnormand b784476
    [EN JE] Add notes to deadlines, voting-options, voter-registration-op…
@ericnormand
  • @ericnormand 0cde4e6
    [EN JE] Use nested maps for deadlines, voting-options, and voter-regi…
@ericnormand
@ericnormand
ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

Possibly. I'm looking into it.

ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

Yes. Thanks.

ericnormand commented on pull request democracyworks/election-works#15
@ericnormand

Yes. It only adds, even if they are identical maps (because they become new entities with different db/ids).

ericnormand commented on pull request democracyworks/kehaar#11
@ericnormand

Hi @cap10morgan! I just merged the backpressure branch to master, hence the conflict. The new scheme is that kehaar.core is low-level stuff, while …

@ericnormand
  • @ericnormand 48ba735
    [EN] Move async->fn test to wire-up-test
ericnormand deleted branch backpressure at democracyworks/kehaar
@ericnormand
@ericnormand
Backpressure
8 commits with 509 additions and 216 deletions
@ericnormand
  • @ericnormand 803f2a9
    [EN] Move async->fn to wire-up
ericnormand commented on pull request democracyworks/kehaar#12
@ericnormand

ping @tie-rack Anything else I can improve on this?

@ericnormand
Store deadlines for elections
11 commits with 916 additions and 35 deletions
@ericnormand
  • @ericnormand 32b418a
    [EN JE] Remove old options when updating options
@ericnormand
ericnormand commented on pull request democracyworks/datomic-toolbox#6
@ericnormand

Of course you're right about the bar potentially being set too high, @cap10morgan. But I agree with @tie-rack on this. The key is to make the bar t…

ericnormand commented on pull request democracyworks/user-http-api#1
@ericnormand

Would be good to pair on this on Friday!

ericnormand commented on pull request democracyworks/user-http-api#1
@ericnormand

Ok. Ran the tests (with lein test), they pass on my machine. LGTM :+1: