Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add typings #44

Merged
merged 1 commit into from Nov 30, 2017
Merged

add typings #44

merged 1 commit into from Nov 30, 2017

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Nov 27, 2017

There are already definitions available on DT, but they're a bit out date. Rather than keep them separate, it's best when bundled directly into the module! That way they stay synced with the API as it changes.

The definition is pretty straightforward and I'm using my fork in a project, so I'm confident it works.

​Let me know if you've got any other questions!

@ericnorris ericnorris merged commit f80b3b8 into ericnorris:master Nov 30, 2017
1 check passed
@ericnorris
Copy link
Owner

ericnorris commented Nov 30, 2017

Hey @xavdid, thanks! I'll tag and release this when I have access to the machine with my GPG keys on it.

@xavdid
Copy link
Contributor Author

xavdid commented Nov 30, 2017

Awesome, thank you! No rush on it, glad it's in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants