Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Faiss #35

Merged
merged 1 commit into from Oct 10, 2017
Merged

Add support for Faiss #35

merged 1 commit into from Oct 10, 2017

Conversation

@benfred
Copy link
Contributor

@benfred benfred commented Sep 27, 2017

This adds basic support for faiss on the cpu as suggested in #34. The timing results on my system seem to be on par with Annoy on the glove dataset:
glove

@erikbern
Copy link
Owner

@erikbern erikbern commented Sep 27, 2017

nice! reminds me i really want to dockerize the tests

@benfred benfred force-pushed the benfred:faiss branch from 524a4f2 to 534cba2 Oct 10, 2017
@benfred
Copy link
Contributor Author

@benfred benfred commented Oct 10, 2017

I think that last commit there actually works on travis (was expecting ubuntu v16 originally, and was running on v14).

Unfortunately there seems to be a bunch of other errors unrelated to this change that will cause the build to be marked as failed. I've fixed the easy ones here benfred@7bf2397 and benfred@f6bb17b . However there still seems to be errors on falconn/nearpy.

Also, I wrote some new python bindings for nmslib a while ago, and updated the ann-benchmarks to use them here: benfred@1aec17c .

If you're interested I can submit PR's for all of these.

@erikbern
Copy link
Owner

@erikbern erikbern commented Oct 10, 2017

seems fine. i'll merge this for now, will revisit the travis integration and also dockerization

@erikbern erikbern merged commit 3608396 into erikbern:master Oct 10, 2017
1 check was pending
1 check was pending
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@erikbern
Copy link
Owner

@erikbern erikbern commented Oct 10, 2017

thanks!

@benfred benfred deleted the benfred:faiss branch Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants