Merged
Conversation
Owner
|
nice! reminds me i really want to dockerize the tests |
Contributor
Author
|
I think that last commit there actually works on travis (was expecting ubuntu v16 originally, and was running on v14). Unfortunately there seems to be a bunch of other errors unrelated to this change that will cause the build to be marked as failed. I've fixed the easy ones here benfred@7bf2397 and benfred@f6bb17b . However there still seems to be errors on falconn/nearpy. Also, I wrote some new python bindings for nmslib a while ago, and updated the ann-benchmarks to use them here: benfred@1aec17c . If you're interested I can submit PR's for all of these. |
Owner
|
seems fine. i'll merge this for now, will revisit the travis integration and also dockerization |
Owner
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds basic support for faiss on the cpu as suggested in #34. The timing results on my system seem to be on par with Annoy on the glove dataset:
