Lexer.x source is missing in tarball #10

Closed
nomeata opened this Issue Apr 22, 2012 · 7 comments

Comments

Projects
None yet
3 participants
@nomeata
Contributor

nomeata commented Apr 22, 2012

This makes the package not legally distributable by, e.g. Debian. (See http://bugs.debian.org/669156). So Lexer.x needs to end up in the tarball.

One way is to just put it in src/ and let Cabal take care of it. Using "setup sdist" will create a tarball with the generated file Lexer.hs in dist/, so that users will not need to have alex installed and in the path to install the library. Unless the modify the source Lexer.x of course.

@nomeata nomeata referenced this issue Apr 22, 2012

Closed

Fix for #10 #11

@alanz

This comment has been minimized.

Show comment
Hide comment
@alanz

alanz Apr 22, 2012

Collaborator

Hi

It is specifically split into the src-dev directory, so people do not need
version >=3 of alex, which is not in the current haskell-platform. I will
add it in the cabal file

Alan

On Sun, Apr 22, 2012 at 11:12 AM, nomeata <
reply@reply.github.com

wrote:

This makes the package not legally distributable by, e.g. Debian. (See
http://bugs.debian.org/669156). So Lexer.x needs to end up in the tarball.

One way is to just put it in src/ and let Cabal take care of it. Using
"setup sdist" will create a tarball with the generated file Lexer.hs in
dist/, so that users will not need to have alex installed and in the path
to install the library. Unless the modify the source Lexer.x of course.


Reply to this email directly or view it on GitHub:
alanz#10

Collaborator

alanz commented Apr 22, 2012

Hi

It is specifically split into the src-dev directory, so people do not need
version >=3 of alex, which is not in the current haskell-platform. I will
add it in the cabal file

Alan

On Sun, Apr 22, 2012 at 11:12 AM, nomeata <
reply@reply.github.com

wrote:

This makes the package not legally distributable by, e.g. Debian. (See
http://bugs.debian.org/669156). So Lexer.x needs to end up in the tarball.

One way is to just put it in src/ and let Cabal take care of it. Using
"setup sdist" will create a tarball with the generated file Lexer.hs in
dist/, so that users will not need to have alex installed and in the path
to install the library. Unless the modify the source Lexer.x of course.


Reply to this email directly or view it on GitHub:
alanz#10

@alanz alanz closed this in 38e507b Apr 22, 2012

@nomeata

This comment has been minimized.

Show comment
Hide comment
@nomeata

nomeata Apr 22, 2012

Contributor

You don’t need to depend on alex to have the alex file in src/, though... but whatever works for you.

Contributor

nomeata commented Apr 22, 2012

You don’t need to depend on alex to have the alex file in src/, though... but whatever works for you.

@alanz

This comment has been minimized.

Show comment
Hide comment
@alanz

alanz Apr 22, 2012

Collaborator

I guess if the Lexer.x and Lexer.hs files are both in src/ it would work as
I want. It just seems clearer to me to have it this way.

But I have added the files in the locations they are currently in.

On Sun, Apr 22, 2012 at 11:35 AM, nomeata <
reply@reply.github.com

wrote:

You don’t need to depend on alex to have the alex file in src/, though...
but whatever works for you.


Reply to this email directly or view it on GitHub:
alanz#10 (comment)

Collaborator

alanz commented Apr 22, 2012

I guess if the Lexer.x and Lexer.hs files are both in src/ it would work as
I want. It just seems clearer to me to have it this way.

But I have added the files in the locations they are currently in.

On Sun, Apr 22, 2012 at 11:35 AM, nomeata <
reply@reply.github.com

wrote:

You don’t need to depend on alex to have the alex file in src/, though...
but whatever works for you.


Reply to this email directly or view it on GitHub:
alanz#10 (comment)

@erikd

This comment has been minimized.

Show comment
Hide comment
@erikd

erikd Apr 22, 2012

Owner

@alanz Any idea when this version is going to be released? I'm one of the Debian haskell guys :-)

Owner

erikd commented Apr 22, 2012

@alanz Any idea when this version is going to be released? I'm one of the Debian haskell guys :-)

@alanz

This comment has been minimized.

Show comment
Hide comment
@alanz

alanz Apr 22, 2012

Collaborator

Within the next ten mins

On Sun, Apr 22, 2012 at 11:40 AM, Erik de Castro Lopo <
reply@reply.github.com

wrote:

@alanz Any idea when this version is going to be released? I'm one of the
Debian haskell guys :-)


Reply to this email directly or view it on GitHub:
alanz#10 (comment)

Collaborator

alanz commented Apr 22, 2012

Within the next ten mins

On Sun, Apr 22, 2012 at 11:40 AM, Erik de Castro Lopo <
reply@reply.github.com

wrote:

@alanz Any idea when this version is going to be released? I'm one of the
Debian haskell guys :-)


Reply to this email directly or view it on GitHub:
alanz#10 (comment)

@alanz

This comment has been minimized.

Show comment
Hide comment
@alanz

alanz Apr 22, 2012

Collaborator

Version 0.5.2 is on hackage, with Lexer.x included

Collaborator

alanz commented Apr 22, 2012

Version 0.5.2 is on hackage, with Lexer.x included

@nomeata

This comment has been minimized.

Show comment
Hide comment
@nomeata

nomeata Apr 22, 2012

Contributor

Thanks a bunch!

Contributor

nomeata commented Apr 22, 2012

Thanks a bunch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment