Test suite fails if locale is not an UTF8 locale #21

Closed
nomeata opened this Issue Oct 20, 2012 · 0 comments

2 participants

@nomeata

Hi,

the environment that Debian builds its packags in do not have a specific locale set (after all, the result should depend on the settings of the particular developer building the package). But without an UTF8 locale, your test suite fails:

  unicode5f: [Failed]
ERROR: ./test/Unicode.js: hGetContents: invalid argument (invalid byte sequence)

Unfortunately, the encoding of .js files is not specified, so you cannot just change the encoding of the filehandle to utf8 in parseFile. Maybe you should not use parseFile in the test suite, but parseJs and read the file with the correct encoding (which you know) set for the filehandle?

@alanz alanz added a commit that closed this issue Oct 21, 2012
@alanz alanz Introduce parseFileUtf8 to explicitly use utf8 for parsing a file, an…
…d update tests to use it where needed. Closes #21
98e5bfe
@alanz alanz closed this in 98e5bfe Oct 21, 2012
@alanz alanz added a commit that referenced this issue Jul 29, 2015
@alanz alanz Introduce parseFileUtf8 to explicitly use utf8 for parsing a file, an…
…d update tests to use it where needed. Closes #21
a1b36e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment