Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cyrillic support #6

Open
Twilightssuperb opened this issue Aug 22, 2022 · 14 comments
Open

Add Cyrillic support #6

Twilightssuperb opened this issue Aug 22, 2022 · 14 comments

Comments

@Twilightssuperb
Copy link

Is it possible to create and implement cyrillic languages support?

@erikdkennedy
Copy link
Owner

I'm open to it. There are many improvements I need to make to the Latin set first (first and foremost, italics), so it won't be soon. But I'll leave this open for now, and others interested can upvote/comment.

@erikdkennedy erikdkennedy changed the title What about Cyrillic glyphs? Add Cyrillic support Aug 23, 2022
@drawcard
Copy link
Contributor

I'm interested in helping out with this. I've made a start at https://github.com/drawcard/figtree/tree/cyrillic

@drawcard
Copy link
Contributor

drawcard commented Oct 4, 2022

I've completed the uppercase and lowercase character set for Cyrillic (Basic set), you can check out my branch to take a closer look.

I'm not a native Cyrillic writer, so it should be looked over by someone who is more familiar with Cyrillic. However I did study quite a few Cyrillic fonts while working on it, so hopefully it hits the mark.

Things to do before PR:

  • Finish kerning pairs (will do some small updates to my branch as this happens)
  • Check that the weight / colour is consistent with latin
  • Final pass to check for technical issues with linework

Future ideas:

  • Support for Ukranian, Belarusian, Bulgarian characters
  • Italic versions

CleanShot 2022-10-04 at 23 19 41@2x

CleanShot 2022-10-04 at 23 14 30@2x

@erikdkennedy
Copy link
Owner

Looks like a fantastic start! Let me try and get some native readers to look it over. Thanks @drawcard ! 🙂

@erikdkennedy
Copy link
Owner

@drawcard I'd like to include Ukrainian with the initial PR.

Ґ ґ Є є І і Ї ї ₴

What else do we need for that?

@drawcard
Copy link
Contributor

drawcard commented Oct 4, 2022

Thanks Erik!

For Ukrainian, I can complete the character set in Glyphs and update the branch. Shouldn't be too much effort to do.

I also posted in TypeDrawers to get some feedback, the comments have been helpful and I'll be working in those suggestions.

Will submit my PR soon!

@Twilightssuperb
Copy link
Author

Twilightssuperb commented Oct 5, 2022

@drawcard, I add some line up to your mockup. It better shows that some letters don't have the same alignment (to bottom or top) and should be a bit smaller. Seems they are Э, Ю and small «е», «ё», «э», «ю». But I'm not sure of my viewpoint. Just glanced some details that could be matter.

Your mockup is fine.

My orange line is 2 px.

Figtree Cyrillic lineage mockup

@drawcard
Copy link
Contributor

drawcard commented Oct 5, 2022

Thanks for this @Twilightssuperb - I'm not entirely sure if I understand the issue, as the rounded letter shapes have overshoots on them, for optical correction, so their extremes wouldn't line up with the other x-heights:

CleanShot 2022-10-05 at 23 29 11@2x

CleanShot 2022-10-05 at 23 29 44@2x

Does that make sense, or does the issue lie somewhere else?

@Twilightssuperb
Copy link
Author

Twilightssuperb commented Oct 5, 2022

Yep, I suggested it. It's not a bug or mistake, it's a typographic feature. Your drafts looks fine, don't bother. 🙂

I'm not a pro or designer to be nerdy or too strict, I'm just a kind of geek.

@drawcard
Copy link
Contributor

drawcard commented Oct 5, 2022

Oh, I see now - thanks for pointing this out anyway!

@lazarljubenovic
Copy link

Serbian always gets left out 😭 ЉЊШЂЖЧЋ 🤟🏻

Here's my feedback for the current state:

  • The lowercase л looks weird, especially in the bold variant. Visually it doesn't feel like the left part is reaching the baseline. The curve should either be snappier (e.g. Monserrat), or the whole left stroke should have a slight slope from the start (e.g. Open Sans).
  • Дs look enormous. The baseline should be at the upper (not lower) edge of the lower horizontal line. (More obvious in the bold version).
  • We write б slightly different in Serbia (see this comparison), so take this with a grain of salt, but I feel like the suggested б is too "wavy" at the top for this font.
  • Ж seems slightly too condensed to the middle. I'd try extending the middle horizontal line and thus slightly reducing the slope of the diagonal strokes.
  • З looks too thin compared to everything else, but I have no concrete suggestion on what to do.

@comerc
Copy link

comerc commented Mar 23, 2024

@drawcard I can't install Cyrillic font on Mac. Please help me.

@comerc
Copy link

comerc commented Mar 23, 2024

photo_2024-03-23_11-31-54

keycaps with this font :)

@thejupitergroup
Copy link

@drawcard I tried to download the fonts from your branch but they don't have the Cyrillic characters. Am I looking in the wrong place?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants