Permalink
Commits on Apr 5, 2013
Commits on Apr 4, 2013
  1. Merge pull request #325 from vipulnsward/fix_attr_warn

    eventualbuddha committed Apr 4, 2013
    refactor fix private attribute warning
  2. Merge pull request #323 from railsaholic/remove_private_attribute_war…

    sferik committed Apr 4, 2013
    …ning
    
    Avoid 'warning: private attribute? '
Commits on Apr 3, 2013
  1. Merge pull request #322 from justincampbell/remove-quotes-from-ask

    sferik committed Apr 3, 2013
    Remove quotes from Shell#ask
  2. Merge pull request #321 from vipulnsward/fix_typo-v1

    sferik committed Apr 3, 2013
    fix some typos
  3. fix some typos

    vipulnsward committed Apr 3, 2013
Commits on Apr 2, 2013
  1. Merge pull request #317 from justincampbell/shell-defaults

    sferik committed Apr 2, 2013
    Add support for a default to Shell::Basic#ask
  2. Merge pull request #320 from spastorino/master

    sferik committed Apr 2, 2013
    Avoid @namespace not initialized warning
Commits on Mar 30, 2013
  1. Prepare for version 0.18.1

    sferik committed Mar 30, 2013
Commits on Mar 28, 2013
Commits on Mar 26, 2013
  1. Merge pull request #316 from josevalim/thor-reverts

    sferik committed Mar 26, 2013
    Revert regressions found in 0.18.0
  2. Allow calling private methods on template names

    josevalim committed Mar 26, 2013
    This is an expected feature from Thor. When rendering files,
    Thor behaves like Sinatra. It works as if the file was embedded
    in the current Thor class. Therefore, restricting the filename
    to be just public methods is a wrong limitation that does not
    fit with how Thor is meant to be used.
  3. Revert "Consider methods added via attr_* no commands"

    josevalim committed Mar 26, 2013
    Althugh there is an issue in here, the current implementation is
    very brittle as looking into the stacktrace is not guaranteed to
    stay the same across different ruby versions and ruby implementations.
    
    This reverts commit fb149e3.
  4. Prepare for version 0.18.0

    sferik committed Mar 26, 2013
Commits on Mar 19, 2013
Commits on Mar 13, 2013
  1. Merge pull request #312 from JoshCheek/master

    sferik committed Mar 13, 2013
    Make error messages more helpful
Commits on Mar 5, 2013
  1. Merge pull request #313 from elgalu/option_exclude_pattern

    sferik committed Mar 5, 2013
    New feature: Add directory() config[:exclude_pattern]
  2. Merge pull request #314 from cynicaljoy/master

    sferik committed Mar 5, 2013
    Updated the README.md
Commits on Mar 4, 2013
Commits on Mar 1, 2013
  1. Error message wording

    JoshCheek committed Mar 1, 2013
    Implements changes suggested by sferik in #312
    
    In the error messages for handling incorrect number of arguments
    
    * Remove branch from if statement that will never be hit.
    * Put error message on two lines
    * Use "arguments" instead of "args"
  2. Make error messages more helpful

    JoshCheek committed Mar 1, 2013
    When passing the wrong number of args to a command, it will now tell you
    what args were passed.
    
    This is useful in cases where it is unclear what the arguments are. For
    example, we were invoking the binary from a script which was not
    properly escaping the arguments that it was forwarding. This caused the
    invocation `--option="1 2"` to be passed as `--option=1 2` and `2` became
    an argument to the command, which took about half an hour to figure out
    (plus, the hour my QA spent trying to figure it out herself before I
    could look at it with her). If it had told me that it was receiving the
    argument `2`, it would have been pretty clear that it was an escaping
    issue.
    
    I removed the arity from the message because in the case of optional
    arguments, it would output a negative number, which is confusing for
    non-rubyists.
    
    I didn't include the signature, because 1.8.7 was listed in the
    .travis.yml, and it does not have the ability to reflect on parameters.
    Plus, again, if the end-user is not a rubyist, then that kind of error
    message would probably be too technical. So instead, just print the
    description.
Commits on Feb 28, 2013
  1. Add directory() config[:exclude_pattern] to prevent copying files tha…

    elgalu committed Feb 28, 2013
    …t match certain regexp
Commits on Feb 27, 2013
  1. Revert "Slightly more sensible error when no args required"

    eventualbuddha committed Feb 27, 2013
    No longer really needed as of dbbfea8.
    
    This reverts commit 8e0c8c9.