Issue 168 #206

Merged
merged 1 commit into from Dec 20, 2011

Conversation

Projects
None yet
3 participants
@kbl
Contributor

kbl commented Dec 20, 2011

Further explanation in comment on #168 issue.

wycats added a commit that referenced this pull request Dec 20, 2011

@wycats wycats merged commit bdf49a5 into erikhuda:master Dec 20, 2011

@@ -114,8 +114,12 @@ def destination_root=(root)
# the script started).
#
def relative_to_original_destination_root(path, remove_dot=true)
- path = path.gsub(@destination_stack[0], '.')
- remove_dot ? (path[2..-1] || '') : path
+ if path =~ /^#{@destination_stack[0]}/

This comment has been minimized.

Show comment Hide comment
@josevalim

josevalim Jun 29, 2012

Contributor

This line will fail if the destination root contains a character that is part of the regexp subset. In other words, you should escape the path before asserting. I have already pushed a fix to master.

@josevalim

josevalim Jun 29, 2012

Contributor

This line will fail if the destination root contains a character that is part of the regexp subset. In other words, you should escape the path before asserting. I have already pushed a fix to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment