Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed newline handling bug in Thor::Shell::Basic#say #257

Merged
merged 1 commit into from Sep 21, 2012

Conversation

Projects
None yet
2 participants
Contributor

km4n commented Sep 20, 2012

Thor::Shell::Basic#say method would suppress newline when message contained whitespace directly followed by a newline embedded within the string (not at the end). Fixed by modifying the offending regex, causing it to match at end of string instead of end of line. Also added related test.

Fixed newline handling bug in Thor::Shell::Basic::say
Method would suppress newline when message contained whitespace directly
followed by a newline embedded within the string (not at the end). Fixed
by modifying the offending regex, causing it to match at end of string
instead of end of line.

eventualbuddha added a commit that referenced this pull request Sep 21, 2012

Merge pull request #257 from km4n/fix-shell-basic-say-force-newline-bug
Fixed newline handling bug in Thor::Shell::Basic#say

@eventualbuddha eventualbuddha merged commit 593722c into erikhuda:master Sep 21, 2012

Contributor

eventualbuddha commented Sep 21, 2012

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment