Skip to content

Adds quality spec #352

Merged
merged 1 commit into from Mar 22, 2014

3 participants

@rthbound
rthbound commented Jul 2, 2013
  • Spec will fail if Thor contains malformed whitespace
  • Spec will fail if Thor's tests use inconsistent quote styles in it/describe/context strings (Thor prefers double-quotes)
  • Run with: rspec spec/quality_spec.rb
@rthbound rthbound Adds quality spec
  - Spec will fail if Thor contains malformed whitespace
  - Spec will fail if Thor's tests use inconsistent quote styles (Thor
    prefers double-quotes)
  - Run with: rspec spec/quality_spec.rb
b38891d
@coveralls

Coverage Status

Coverage remained the same when pulling b38891d on rthbound:adds-quality-spec into 17bb8e6 on erikhuda:master.

@rthbound
rthbound commented Jul 2, 2013

Borrowed this spec from the bundler project.

@sferik
Erikhuda member
sferik commented Dec 15, 2013

Hey, thanks for submitting this patch. I just added rubocop to enforce similar rules. I actually switched this project’s style to prefer single-quoted strings when there’s no string interpolation or special symbols (e.g. \n, \r, \t).

If you made these changes to this patch, I’d still merge this, since rubocop is not part of the build process.

@sferik sferik merged commit ea7bb84 into erikhuda:master Mar 22, 2014

1 check passed

Details default The Travis CI build passed
@rthbound rthbound deleted the rthbound:adds-quality-spec branch Mar 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.