Add name parameter to field level validation #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Field Level Validation example documents three parameters (`value`, `allValues`, and `props`) but the function accepts `name` as its fourth parameter. This appears to have been added in redux-form#3364; while the signature as updated in `docs/api/Field.md`, it was not updated in the examples.
Codecov Report
@@ Coverage Diff @@
## master #4133 +/- ##
======================================
Coverage 100% 100%
======================================
Files 72 72
Lines 1666 1666
======================================
Hits 1666 1666Continue to review full report at Codecov.
|
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
|
Published in |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Field Level Validation example documents three parameters (
value,allValues, andprops) but the function acceptsnameas its fourth parameter. This appears to have been added in #3364; while the signature as updated indocs/api/Field.md, it was not updated in the examples.