Letsencrypt auto release #2
Conversation
- move them to the top for clarity - accept them in any position - shadow & document them in the Python client
pde
force-pushed
the
letsencrypt-auto-release
branch
from
aa67cfa
to
1b3c8e8
Compare
| elif [ "$arg" = "--no-self-upgrade" ] ; then | ||
| # Do not upgrade this script (also prevents client upgrades, because each | ||
| # copy of the script pins a hash of the python client) | ||
| NO_SELF_UPGRADE=1 |
There was a problem hiding this comment.
Unfortunately, this means the client has to be aware of all le-auto flags, though they do nothing there. If we could come up with a plain-Bourne way of slicing the le-auto args out of the arg list, we wouldn't have to do that. Any ideas? Bourne supports only the single array, $@, and has no slicing ops.
There was a problem hiding this comment.
I suppose we could have a Python script do the slicing, but that's even more complicated. Let's keep this for now.
There was a problem hiding this comment.
On the plus side, if the python code knows about these flags, then it can also provide documentation for them.
There was a problem hiding this comment.
This is true. Wrapper scripts that want to have their own flags are tricky, as I learned with peep.
erikrose
force-pushed
the
letsencrypt-auto-release
branch
5 times, most recently
from
bcdf0c5
to
ed56264
Compare
|
I tried the merge but found that it failed one of the In other words, it doesn't seem to install a letsencrypt script that prints its version when passed --version. |
erikrose
force-pushed
the
letsencrypt-auto-release
branch
2 times, most recently
from
1899f8e
to
7ee23b7
Compare
…ove le-auto's option parsing. If the new le-auto tests well in the minutes or hours after release, we'll make another commit to master that removes the old le-auto stuff. Close #2.
…ove le-auto's option parsing. If the new le-auto works well in the minutes or hours after release, we'll make another commit to master that removes the old le-auto and bootstrap scripts. Close #2.
|
Rolled back and re-merged in d813097. |
Make certbot-route53 python3 compatible
Various updates including some client integration with the new leauto.