Type check when comparing nodes #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikrose
requested changes
Sep 22, 2016
| @@ -90,6 +90,9 @@ def __str__(self): | |||
|
|
|||
| def __eq__(self, other): | |||
| """Support by-value deep comparison with other nodes for testing.""" | |||
| if not isinstance(other, Node): | |||
| return NotImplemented | |||
|
|
|||
| return (other is not None and | |||
There was a problem hiding this comment.
Since we're doing the isinstance() test above, we can lose the other is not None clause.
|
|
||
| def test_node_inequality(): | ||
| node = Node('text', 'o hai', 0, 5) | ||
| assert node != 5 |
There was a problem hiding this comment.
For consistency and to work properly under python -O (rather than getting optimized out), let's import ok_ from nose.tools and do ok_(node != 5). Since we're removing the explicit None checking above, it might also not be a bad idea to test equality against None if we're not doing it elsewhere.
There was a problem hiding this comment.
Absolutely! I am mostly familiar with pytest and not much with nose, so I just hacked away at it until I had a failing test.
It should be covered by the isinstance above
erikrose
approved these changes
Sep 22, 2016
|
Thanks again for the good patch! :-D |
|
I didn't know about the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should close #95 by making the
Nodegive up comparisons with things that are not of its class.I went with returning
NotImplementedas that givesothera chance to do the comparison.I thought about using
But I don't really know what is the preferred style, so I just went with the simpler.