Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jun 17, 2012
  1. [Locale][TwigBridge][FrameworkBundle] implementation of localizaded f…

    authored
    …ormatters for currency and date/time
  2. @fabpot

    merged branch aerialls/patch-2 (PR #4597)

    fabpot authored
    Commits
    -------
    
    dacd8aa tweaked UPGRADE file
    
    Discussion
    ----------
    
    tweaked UPGRADE file
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-16T16:56:55Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1635992) (merged dacd8aa into bc147d3).
Commits on Jun 16, 2012
  1. @aerialls

    tweaked UPGRADE file

    aerialls authored
  2. @fabpot

    merged branch aerialls/fs_exists (PR #4586)

    fabpot authored
    Commits
    -------
    
    38cad9d [Filesystem] added exists method
    
    Discussion
    ----------
    
    [Filesystem] added exists method
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets:
    Todo:
    License of the code: MIT
    Documentation PR:
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-15T16:29:20Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1629204) (merged ebd1a4c6 into f881d28).
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-06-16T09:05:48Z
    
    Shouldn't it be better to stop on the first failure? as all the others files will be false automatically.
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-06-16T10:21:49Z
    
    indeed. We should avoid unnecessary filesystem IO by returning false as soon as it is known
    
    ---------------------------------------------------------------------------
    
    by aerialls at 2012-06-16T11:55:24Z
    
    Indeed it's better this way. fixed!
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-16T12:01:16Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1634615) (merged 8d98f417 into 76b2ed4).
  3. @fabpot

    merged branch shieldo/fix_docblock_typo (PR #4590)

    fabpot authored
    Commits
    -------
    
    bfe5e58 [Form] fixed typo in docblock
    
    Discussion
    ----------
    
    [Form] fixed typo in docblock
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-15T20:03:08Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1630865) (merged bfe5e58 into f881d28).
  4. @fabpot

    merged branch henrikbjorn/editorconfig (PR #4595)

    fabpot authored
    Commits
    -------
    
    b6001cf Add EditorConfig File
    
    Discussion
    ----------
    
    Add EditorConfig File
    
    http://editorconfig.org is a way to configure the different editor
    configurations.
    
    This could help some who develop with ruby and php where ruby uses 2
    spaces and we use 4. Or where some develop for Drupal where they also
    use 2 spaces but 4 for contributing to Symfony.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-16T12:14:54Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1634672) (merged b6001cf into 76b2ed4).
  5. @fabpot
  6. @aerialls
  7. @henrikbjorn

    Add EditorConfig File

    henrikbjorn authored
    http://editorconfig.org is a way to configure the different editor
    configurations.
    
    This could help some who develop with ruby and php where ruby uses 2
    spaces and we use 4. Or where some develop for Drupal where they also
    use 2 spaces but 4 for contributing to Symfony.
  8. @fabpot

    moved validator translation files to the Form and Validator component…

    fabpot authored
    …s to make them reusable (closes #4588)
Commits on Jun 15, 2012
  1. @shieldo

    [Form] fixed typo in docblock

    shieldo authored
  2. @fabpot

    [Validator] avoid to get information from the cache when we already h…

    fabpot authored
    …ave them locally (also fixes usage of this class when not using a cache)
Commits on Jun 14, 2012
  1. @fabpot

    merged branch shieldo/fix_docblock (PR #4579)

    fabpot authored
    Commits
    -------
    
    9e71b42 [Validator] fixed typo in docblock
    
    Discussion
    ----------
    
    [Validator] fixed typo in docblock
  2. @shieldo
  3. @fabpot
Commits on Jun 13, 2012
  1. @fabpot

    merged branch SamsonIT/remove_symlink_on_windows (PR #4565)

    fabpot authored
    Commits
    -------
    
    fc3ebb8 [FileSystem] added if-windows check
    0b58828 [FileSystem] remove symlinks under windows
    
    Discussion
    ----------
    
    [FileSystem] remove symlinks under windows
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    When installing assets on Windows with symlink, the following error occurs when symlink-folders already exist. This PR makes sure symlink-folders are removed under Windows.
    
    ```
    $ app/console assets:install web --symlink
    Installing assets using the symlink option
    Installing assets for Symfony\Bundle\FrameworkBundle into web/bundles/framework
    
      [ErrorException]
      Warning: symlink(): Cannot create symlink, error code(1314) in C:\workspace\erik\roompot\vendor\symfony\symfony\src\Symfony\Component\Filesystem\Filesystem.php line 167
    
    assets:install [--symlink] [--relative] target
    ```
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T09:00:42Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1608541) (merged 0b58828 into 37550d2).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T14:39:32Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1611288) (merged fc3ebb8 into 0f67ca8).
  2. @ErikTrapman
  3. @fabpot
  4. @fabpot

    merged branch kriswallsmith/head-streamed-response-err (PR #4502)

    fabpot authored
    Commits
    -------
    
    280fc05 failing test for HEAD StreamedResponse requests
    
    Discussion
    ----------
    
    [WIP] failing test for HEAD StreamedResponse requests
    
    An exception is thrown if you prepare a StreamedResponse with a HEAD request. I'm not sure what the right fix is…
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2012-06-06T15:51:04Z
    
    The Travis build is here: http://travis-ci.org/#!/symfony/symfony/builds/1543352
    
    ---------------------------------------------------------------------------
    
    by sstok at 2012-06-08T11:07:31Z
    
    Well a HEAD can't/shouldn't be streamed as it doesn't contain a body so what is the real problem here?
    
    ---------------------------------------------------------------------------
    
    by kriswallsmith at 2012-06-08T16:14:18Z
    
    @sstok the response is prepared by the ResponseListener regardless of request method
    
    ---------------------------------------------------------------------------
    
    by adrienbrault at 2012-06-08T19:41:27Z
    
    Shouldn't the test at least assert something ?
  5. @fabpot

    merged branch stof/change_typehint (PR #4569)

    fabpot authored
    Commits
    -------
    
    92e028f Changed the typehint in the LocaleListener
    
    Discussion
    ----------
    
    Changed the typehint in the LocaleListener
    
    The listener does not depend on the RouterInterface but only on the
    RequestContextAwareInterface which is also implemented by the matcher
    and the generator. Changing the typehint allow reusing the listener
    in Silex.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T14:12:10Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1611055) (merged 92e028f into 1d7501d).
  6. @stof

    Changed the typehint in the LocaleListener

    stof authored
    The listener does not depend on the RouterInterface but only on the
    RequestContextAwareInterface which is also implemented by the matcher
    and the generator. Changing the typehint allow reusing the listener
    in Silex.
  7. @fabpot

    merged branch stealth35/fs_micropt (PR #4568)

    fabpot authored
    Commits
    -------
    
    abab929 Prevent empty value in isAbsolutePath, use rtrim in mirror
    
    Discussion
    ----------
    
    Prevent empty value in isAbsolutePath, use rtrim in mirror
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: [![Build Status](https://secure.travis-ci.org/stealth35/symfony.png?branch=fs_micropt)](http://travis-ci.org/stealth35/symfony)
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T13:39:39Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1610607) (merged abab929 into 3ab9a6e).
  8. @fabpot
  9. @stealth35
  10. @fabpot

    merged branch merk/patch-2 (PR #4561)

    fabpot authored
    Commits
    -------
    
    4ac48d9 Added failing YAML inline string to tests
    
    Discussion
    ----------
    
    Added failing YAML inline string to tests
    
    #4042 introduced a regression for yaml string parsing starting with a double colon (::). The below configuration syntax no longer works.
    
    The addition to the tests generates a failure:
    
    1) Symfony\Component\Yaml\Tests\InlineTest::testDump
    Symfony\Component\Yaml\Exception\ParseException: Malformed inline YAML string ('::form_base.html.twig').
    
    ```yaml
    # Twig Configuration
    twig:
        debug:            %kernel.debug%
        strict_variables: %kernel.debug%
        form:
            resources:
                - '::form_theme.html.twig'
                - 'InfiniteFormBundle::form_theme.html.twig'
    ```
    
    ---------------------------------------------------------------------------
    
    by merk at 2012-06-12T22:15:42Z
    
    For those having this trouble, locking composer at a specific symfony commit is the best option until it is fixed:
    
    ```
            "symfony/symfony": "dev-master#3bb7dc0bfa87b2d4db8262be65b5f49cc6a17a9b",
    ```
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T00:44:45Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1605553) (merged 4ac48d9 into 37550d2).
  11. @ErikTrapman
  12. @fabpot

    merged branch Tobion/eager (PR #4562)

    fabpot authored
    Commits
    -------
    
    49e9957 added test to ensure matching is eager
    
    Discussion
    ----------
    
    [Routing] added test to ensure matching is eager
    
    This just adds a passing test that wasn't covered yet, so we don't break this scenario in the future.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T01:04:09Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1605738) (merged 49e9957 into 37550d2).
  13. @fabpot

    merged branch michelsalib/patch-2 (PR #4564)

    fabpot authored
    Commits
    -------
    
    be637b5 Add upgrade for commit 0995b1f
    
    Discussion
    ----------
    
    Add upgrade for UserPassword moving from Bundle to Component
    
    Just add some documentation in the Upgrade file about the `UserPassword` moving from Bundle to Component in commit 0995b1f.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-13T01:23:49Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1606080) (merged be637b5 into 37550d2).
Commits on Jun 12, 2012
  1. @michelsalib
  2. @merk
  3. @fabpot

    merged branch Burgov/enhance_form_error_message (PR #4557)

    fabpot authored
    Commits
    -------
    
    b5cf337 [Form] Enhanced the form error message
    
    Discussion
    ----------
    
    [Form] Enhanced the form error message
    
    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    The error message on type mismatch is a bit obscure:
    
    The form's view data is expected to be an instance of class Samson\Bundle\TRSBundle\Entity\Labour, but has the type object. You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms object to Samson\Bundle\TRSBundle\Entity\Labour.
    
    This commit changes it to:
    
    The form's view data is expected to be an instance of class Samson\Bundle\TRSBundle\Entity\Labour, but is an instance of class Closure. You can avoid this error by setting the "data_class" option to null or by adding a view transformer that transforms an instance of Closure to an instance of class Samson\Bundle\TRSBundle\Entity\Labour.
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T14:04:08Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601478) (merged 70a15df6 into 7783969).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T14:06:31Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601507) (merged 12ec4dbd into 7783969).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T14:13:09Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1601517) (merged b5cf337 into 7783969).
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-06-12T18:21:31Z
    
    :+1: Thanks!
  4. @fabpot

    merged branch Burgov/builder_getparent_call_fix (PR #4556)

    fabpot authored
    Commits
    -------
    
    1e83206 [Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore)
    
    Discussion
    ----------
    
    [Form] FormBuilderInterface->getParent() doesn't take any arguments (anymore)
    
    Bug fix: yes
    Feature addition: no
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T13:43:25Z
    
    This pull request [fails](http://travis-ci.org/symfony/symfony/builds/1601018) (merged 9826ca66 into 7783969).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-12T13:51:33Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1601030) (merged 1e83206 into 7783969).
    
    ---------------------------------------------------------------------------
    
    by bschussek at 2012-06-12T18:21:56Z
    
    :+1: Thanks again! :)
  5. @fabpot

    merged branch Seldaek/route-gen (PR #4534)

    fabpot authored
    Commits
    -------
    
    31843cf [FrameworkBundle] Add info to config
    d5ab4c1 [Routing] Update changelog
    bbef65e [Routing] Add strict_parameters option to disable exceptions when a route generation fails due to an invalid parameter
    
    Discussion
    ----------
    
    [Routing] Add strict_parameters option to disable exceptions on invalid parameters
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-09T15:07:26Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1577025) (merged bbef65e into 37678e1).
    
    ---------------------------------------------------------------------------
    
    by stof at 2012-06-09T15:43:48Z
    
    Seems good, but you forgot to update the Changelog of the component. Anyway, let's wait for @vicb's review as he knows the Routing component better than me.
    
    ---------------------------------------------------------------------------
    
    by Seldaek at 2012-06-09T16:35:56Z
    
    I updated the changelog
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-09T16:38:31Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1577716) (merged d5ab4c1 into 37678e1).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-11T10:10:37Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1590901) (merged a54e59e4 into 37678e1).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-11T13:50:21Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1591926) (merged 31843cf into 0995b1f).
  6. @fabpot

    merged branch Tobion/phpdoc (PR #4539)

    fabpot authored
    Commits
    -------
    
    680e732 [Routing] fix phpDoc
    
    Discussion
    ----------
    
    [Routing] fix phpDoc
    
    using inheritdoc where possible and removing api tag when parent interface has one
    as requested by stof and fabpot
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-09T16:14:53Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1577508) (merged 0a44632a into f8a09db).
    
    ---------------------------------------------------------------------------
    
    by travisbot at 2012-06-10T19:36:25Z
    
    This pull request [passes](http://travis-ci.org/symfony/symfony/builds/1585766) (merged 680e732 into 7bec078).
Something went wrong with that request. Please try again.