Detachedcallback

Remove resize-listener when detached
erikwett · Sep 14, 2015 · f561561 · f561561
1 parent d85c3d9
commit f561561
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -44,8 +44,7 @@ Or [download as ZIP](https://github.com/erikwett/upper88-wordcloud/archive/maste
 
 Attribute     | Options     | Default      | Description
 ---           | ---         | ---          | ---
-rows          | *Array*     | none         | An array of arrays. First value in each array is the text,
-              |             |              |  second is the value
+rows          | *Array*     | none         | An array of arrays. First value in each array is the text,second is the value
 options       | *Object*    |              | Options. Current options are: maxFont (default 24), minFont (default 12)
 
 

diff --git a/bower.json b/bower.json
@@ -1,6 +1,6 @@
 {
     "name": "upper88-wordcloud",
-    "version": "0.1.0",
+    "version": "0.1.1",
     "description": "Word Cloud Custom Element",
     "license": "MIT",
     "main": "upper88-wordcloud.html",

diff --git a/index.html b/index.html
@@ -15,7 +15,7 @@
         upper88-wordcloud {
             height: 600px;
             width: 80%;
-            background-color: lightgreen;
+            background-color: lightgray;
             position:absolute;
             border-color: black;
             border-style: solid;

diff --git a/upper88-wordcloud.html b/upper88-wordcloud.html
@@ -31,15 +31,14 @@
 
 		element.attachedCallback = function() {
 			var me = this;
-			window.addEventListener("resize", function() {
-				render(me);
-			});
-			setTimeout(function() {
-				render(me);
-			}, 100);
+            me.redraw = function(){render(me);};
+			window.addEventListener("resize", me.redraw);
+			setTimeout(me.redraw, 100);
 		};
 
-		element.detachedCallback = function() {};
+		element.detachedCallback = function() {
+            window.removeEventListener("resize",this.redraw);
+        }
 
 		element.attributeChangedCallback = function(attr, oldVal, newVal) {
 			render(this);