Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fixed (OS X ?) Problem #1

Merged
merged 5 commits into from Apr 14, 2012

Conversation

Projects
None yet
2 participants
Contributor

pdaether commented Apr 13, 2012

Hello @erinata ,

on my Laptop with OS X 10.6.8 the MarkdownBuild plugin did not work.
The html was generated but no browser window popped up.

So i changed the last call and know everything just works. Maybe you want to test this change on windows an push it to your repository.

Greetings
Patrick

Owner

erinata commented Apr 13, 2012

I cannot look at it now because I am on the go. But I will look at it and and want to send a BIG THANKS to you. I am not a mac user and I am very grateful that some one help me to make it work in mac.

Owner

erinata commented Apr 13, 2012

Hey I try that out but it seem that I cannot get it work......

I got

ImportError: No module named desktop

So it seems that there is nothing named "desktop" for me to import. In the mac version of Sublime Text 2 the python has desktop for importing?

Contributor

pdaether commented Apr 14, 2012

You are right. I had this lib on my laptop.

But i had changed the open method again. If you call the open_url command not with just the file path but with a complete URI scheme it works on my computer.
Maybe this does the trick?

URL-encode the file path before calling the 'open_url' command.
Otherwise some errors may occur if the file path contains spaces or special characters.
Owner

erinata commented Apr 14, 2012

if you use the liburl quote....it doesn't work on windows anymore.

Can you try the lastest version out on mac? It use import webbrowser and webbrowser.open("file://" + output.name) to do the trick, and it works on both window and linux.

If it still doesn't work on macI guess I can just put a conditional statement to check the platform.

Contributor

pdaether commented Apr 14, 2012

webbrowser.opendoes the trick on osx also without further modifications.
I think we're done.

erinata added a commit that referenced this pull request Apr 14, 2012

Merge pull request #1 from pdaether/master
Fixed OS X and Linux Problem

@erinata erinata merged commit c187a62 into erinata:master Apr 14, 2012

Owner

erinata commented Apr 14, 2012

Thanks so much for your help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment