Extras #82

Open
maandree opened this Issue Aug 22, 2012 · 12 comments

Comments

Projects
None yet
2 participants
Collaborator

maandree commented Aug 22, 2012

Enhancement that came up in issue #46

-f "Pinkie Pie" -e "Cannon" is the same thing as -f pinkiepie_cannon [the current name is pinkiecannon]
That is how it is described in issue 46. However I think it is better if this feature uses a file structure in
/usr/share/ponysay/extras where pinkiepie is a directory which contains the file cannon which contains
the text pinkiecannon. pinkiecannon is than looked up in the pony directories.

Multiple -e can be used for a -f and -e applies to the last previous -f.
-e must not be without a -f.
The argument parser must be extended with a feature to bind -e to -f for this.

If no -e is used for -f one is selected at random if the -f has upper case.

When implementing this, also implement removal of space even if this feature is not used.
+q can be added to support -e for -q, -q is variadic and consumes all following arguments.

Collaborator

maandree commented Nov 4, 2012

Now with metadata in ponysay 3, this can be better implemented:

Remove --pony as an alternative to -f, and remove ++pony as an alternative to +f.

Make the new option -p with the alternative --pony and +p with the alternative ++pony.

-p and +p (standard ponies and extra ponies) are looked up by NAME and OTHER NAMES in the metadata,
this are stored in a file named extras for each pony directory.

The file extras also contains all extras with mapping to a pony file.

-e should should work as initially described (associated with a -f, +f or -F).

-P should be both -p and +p at the same them.

Do not use +q as described, we should reserve +q and -Q for pony quote future use.
Instead +Q should take no argument as be associated a -p, +p, -P, -f, +f, -F or -e,
and mean that if what the option enables is used, pony quotes should be used.

Collaborator

jristz commented Nov 5, 2012

but aht tags the metadata support? and is ponytools/ponysay-tool readi for making new metaponydata??

Collaborator

maandree commented Nov 5, 2012

Everything should work, but I forgot to mention one thing, the name of the tag this feature use is named EXTRA.

P.S. In the next version of util-say the command img2ponysay &a will be bundled into one command named ponytool,
so when referring to ponysay-tool using the name ponysay-tool or the tool chest may be best.

Edit: ponytools unambiguously refers to ponysay-tool, but it is just one 's' appended to ponytool.

Collaborator

jristz commented Nov 5, 2012

keyborads I hate you....

Ok actually what tags support (or are the suggested) for inclusion in ponies (like NAME or name, TYPE or type or Type)???

Collaborator

maandree commented Nov 5, 2012

Technically you can add any tag as long as it only contains uppercase A–Z [at least one] and blankspaces.
But the recommendation is described at chapter 6 ‘Pony metadata’ (currently at page 12–15).

Collaborator

maandree commented Nov 5, 2012

I've decided to name the tag POSE instead of EXTRA, I think it is more descriptive.

Also for extraponies you can add the tag BASED ON with either the name of a pony
that the extrapony is based (if the original pony is not from MLP:FiM, the name a value
that pony's MEDIA tag can used inside brackets, for example "(Tumblr)", after the
ponyname). If the pony is not based on any pony the value "(original)" can be used.
I do not recommend using BASED ON on standard ponies if the original pony have
same name.

Collaborator

jristz commented Nov 14, 2012

I try to implement all tose options, but for the 'GROUP NAME' in ace (now backgound) I cannot remove it ._.
bug or file bug or file permission problems??

Collaborator

maandree commented Nov 14, 2012

It's a bug, I'm looking into it.

Collaborator

maandree commented Nov 14, 2012

Fixed.

Collaborator

jristz commented Dec 19, 2012

ok the commit named 'Lyra' ( bf97385 ) finally complete all minimal metadata for single-pony
the remaining are double and triple ponies like cutiemarkcrusader, pinkiehugsfluttershy, lyrabonbon and other

with minimal metadata is (groupname, name, optname, mane, tail,eye, appearance, free-or-not, based-on, source, kind, media)

remaining is watch mising single-ponies and multiple-ponies and add metadata and fix problem in there
but the 'minimal is there'

Collaborator

jristz commented Mar 14, 2013

Updating state of Metadata:
in theory metadata for ponies are complete now
the remaining is for extraponies

Collaborator

maandree commented Apr 4, 2013

Postponing to version 3.1, so 3.0 can be released sooner, hopefully today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment