OTP 24.0 unable to find crypto OpenSSL lib

[jj1bdx]

Describe the bug

lib/crypto/configure of OTP 24.0 on macOS 10.15.7 was unable to find the shared library /usr/local/opt/openssl/lib/libcrypto.a.

(Edited: This bug was first discovered when running under parallel configure execution. Using --disable-parallel-configure solves the issue in some cases but not the root cause.)

(Edited 2: a workaround for this bug is posted as a comment here)

(Edited 3: this issue is NOT specific to macOS, reproducible on Ubuntu 20.10 when using autoconf-2.71 instead of stock autoconf-2.69)

To Reproduce

Running the following script as script.sh 24.0

#!/bin/sh
# For macOS with HomeBrew OpenSSL
OTP_VERSION=$1
# SSL path is configured in standard path of lib/crypto/configure.in
#OPENSSL_LOCAL="/usr/local/opt/openssl"
INSTALL_DIR_PREFIX="/Users/kenji/otp/"
#
env \
    CC=/usr/local/opt/ccache/libexec/clang \
    CXX=/usr/local/opt/ccache/libexec/clang++ \
    CFLAGS="-O3 -fstack-protector-strong" LDFLAGS="-fstack-protector-strong" \
    MAKEFLAGS="-j12" \
    KERL_BUILD_PLT="yes" \
    # --disable-parallel-configure required to avoid malfunction of
    # lib/crypto/configure, failing to detect libcrypto.dylib
    KERL_CONFIGURE_OPTIONS="--enable-jit --enable-m64-build --enable-darwin-64bit --disable-vm-probes --disable-native-libs --enable-kernel-poll --enable-dirty-schedulers --enable-sharing-preserving --enable-lock-counter --enable-esock --disable-sctp --without-javac --without-odbc --enable-threads --enable-smp-support --with-wx --disable-silent-rules --with-ssl --disable-dynamic-ssl-lib" \
    KERL_BUILD_DOCS="yes" \
    sh -c "(kerl build git https://github.com/jj1bdx/otp/ OTP-${OTP_VERSION} ${OTP_VERSION} && kerl install ${OTP_VERSION} ${INSTALL_DIR_PREFIX}${OTP_VERSION})"

Causes the following output (note that repository jj1bdx/otp is identical fork as erlang/otp):

% script.sh 24.0
Checking out Erlang/OTP git repository from https://github.com/jj1bdx/otp/...
Building Erlang/OTP 24.0 from git, please wait...
Configure failed.
checking for compiler flags for loadable drivers... -Werror=undef -Werror=implicit -Werror=return-type  -Wdeclaration-after-statement -Wall -Wstrict-prototypes -Wmissing-prototypes  -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS -fno-common -m64 -O3 -fstack-protector-strong -fPIC -fno-common
checking for linker for loadable drivers... clang
checking for linker flags for loadable drivers... -m64 -bundle -bundle_loader /Users/kenji/.kerl/builds/24.0/otp_src_git/bin/x86_64-apple-darwin19.6.0/beam.smp
checking for 'runtime library path' linker flag... not found
checking for multiarch directory... not found
checking size of void *... 8
checking for static zlib... no
checking for OpenSSL header in /usr/local/Cellar/openssl@1.1/1.1.1k... yes
checking for OpenSSL in /usr/local/Cellar/openssl@1.1/1.1.1k... configure: error: static linking against crypto library disabled by user, but no dynamic library found in /usr/local/Cellar/openssl@1.1/1.1.1k
ERROR: /Users/kenji/.kerl/builds/24.0/otp_src_git/lib/crypto/configure failed!

Please see /Users/kenji/.kerl/builds/24.0/otp_build_git.log for full details.

Expected behavior
The build should have been ongoing properly without --disable-parallel-configure.

Affected versions
24.0

Additional context
Building without parallelism by make (without -j option) in the building directory did not cause this bug.

Even with this workaround, the build was failed as follows:

Checking out Erlang/OTP git repository from https://github.com/jj1bdx/otp/...
Building Erlang/OTP 24.0 from git, please wait...
APPLICATIONS DISABLED (See: /Users/kenji/.kerl/builds/24.0/otp_build_git.log)
 * jinterface     : Java compiler disabled by user
 * odbc           : User gave --without-odbc option

APPLICATIONS INFORMATION (See: /Users/kenji/.kerl/builds/24.0/otp_build_git.log)
 * wx             : wxWidgets was not compiled with --enable-webview or wxWebView developer package is not installed, wxWebView will NOT be available

DOCUMENTATION INFORMATION (See: /Users/kenji/.kerl/builds/24.0/otp_build_git.log)
 * documentation  :
 *                  fop is missing.
 *                  Using fakefop to generate placeholder PDF files.

Build failed.
gmake[4]: x86_64-apple-darwin19.6.0/Makefile: No such file or directory
gmake[4]: *** No rule to make target 'x86_64-apple-darwin19.6.0/Makefile'.  Stop.
gmake[4]: Leaving directory '/Users/kenji/.kerl/builds/24.0/otp_src_git/lib/crypto/c_src'
gmake[3]: *** [/Users/kenji/.kerl/builds/24.0/otp_src_git/make/run_make.mk:35: opt] Error 2
gmake[3]: Leaving directory '/Users/kenji/.kerl/builds/24.0/otp_src_git/lib/crypto/c_src'
gmake[2]: *** [/Users/kenji/.kerl/builds/24.0/otp_src_git/make/otp_subdir.mk:29: opt] Error 2
gmake[2]: Leaving directory '/Users/kenji/.kerl/builds/24.0/otp_src_git/lib/crypto'
gmake[1]: *** [/Users/kenji/.kerl/builds/24.0/otp_src_git/make/otp_subdir.mk:29: opt] Error 2
gmake[1]: Leaving directory '/Users/kenji/.kerl/builds/24.0/otp_src_git/lib'
gmake: *** [Makefile:498: libs] Error 2

[jj1bdx]

The build was failed. I've edited the base article of this issue.

[jj1bdx]

I've noticed there was a massive change in b354ab8 between 24.0-rc3 and 24.0. I couldn't figure out the details of the changes.

[LouisMT]

Same issue using asdf-erlang:

$ asdf install erlang ref:OTP-24.0
asdf_OTP-24.0 is not a kerl-managed Erlang/OTP installation
No build named asdf_OTP-24.0
Checking out Erlang/OTP git repository from https://github.com/erlang/otp.git...
Building Erlang/OTP asdf_OTP-24.0 from git, please wait...
Configure failed.
checking for compiler flags for loadable drivers... -Werror=undef -Werror=implicit -Werror=return-type  -Wdeclaration-after-statement -Wall -Wstrict-prototypes -Wmissing-prototypes  -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS -fno-common -g -O2 -fPIC -fno-common
checking for linker for loadable drivers... gcc
checking for linker flags for loadable drivers... -m64 -bundle -bundle_loader /Users/louis/.asdf/plugins/erlang/kerl-home/builds/asdf_OTP-24.0/otp_src_git/bin/x86_64-apple-darwin20.4.0/beam.smp
checking for 'runtime library path' linker flag... not found
checking for multiarch directory... not found
checking size of void *... (cached) 8
checking for static zlib... no
checking for OpenSSL header in /usr/local/opt/openssl@1.1... yes
checking for OpenSSL in /usr/local/opt/openssl@1.1... configure: error: neither static nor dynamic crypto library found in /usr/local/opt/openssl@1.1
ERROR: /Users/louis/.asdf/plugins/erlang/kerl-home/builds/asdf_OTP-24.0/otp_src_git/lib/crypto/configure failed

I was able to build one of the RCs without any problems as well.

[jj1bdx]

Yes, 24.0-rc3 was buildable.

[rickard-green]

@jj1bdx I have no idea why --disable-parallel-configure behaved differently than without it. I'm not able to reproduce that. It seems like configure in crypto was not run when you passed --disable-parallel-configure, but lets look at the other scenario when you did not pass it.

Please attach the lib/crypto/config.log file, and also do an ls /usr/local/Cellar/openssl@1.1/1.1.1k/{lib,lib64,lib/64} and paste the result in a comment.

[rickard-green]

@LouisMT Please attach the lib/crypto/config.log file, and also do an ls /usr/local/opt/openssl@1.1/{lib,lib64,lib/64} and paste the result in a comment.

[wojtekmach]

I'm running into the same problem, I'm on latest master:

lib/crypto/config.log

% ls -l /usr/local/opt/openssl@1.1/lib
total 15144
drwxr-xr-x  4 wojtek  staff      128 Mar 25 14:28 engines-1.1
-r--r--r--  1 wojtek  staff  2437024 Apr 10 21:22 libcrypto.1.1.dylib
-r--r--r--  1 wojtek  staff  4087176 Mar 25 14:28 libcrypto.a
lrwxr-xr-x  1 wojtek  staff       19 Mar 25 14:28 libcrypto.dylib -> libcrypto.1.1.dylib
-r--r--r--  1 wojtek  staff   502872 Apr 10 21:22 libssl.1.1.dylib
-r--r--r--  1 wojtek  staff   723992 Mar 25 14:28 libssl.a
lrwxr-xr-x  1 wojtek  staff       16 Mar 25 14:28 libssl.dylib -> libssl.1.1.dylib
drwxr-xr-x  5 wojtek  staff      160 Apr 10 21:22 pkgconfig
~/src/otp[master]%

[lukebakken]

Thanks to @rickard-green 's help on the mailing list, I get to the point where I see the error reported here.

$ sw_vers 
ProductName:	macOS
ProductVersion:	11.3
BuildVersion:	20E232

$ ls -la "$(brew --prefix openssl)"/{lib,lib64,lib/64}
ls: /usr/local/opt/openssl/lib/64: No such file or directory
ls: /usr/local/opt/openssl/lib64: No such file or directory
/usr/local/opt/openssl/lib:
total 15144
drwxr-xr-x  10 lbakken  staff      320 Mar 25 06:28 .
drwxr-xr-x  14 lbakken  staff      448 Mar 31 14:22 ..
drwxr-xr-x   4 lbakken  staff      128 Mar 25 06:28 engines-1.1
-r--r--r--   1 lbakken  staff  2437024 Mar 31 14:22 libcrypto.1.1.dylib
-r--r--r--   1 lbakken  staff  4087176 Mar 25 06:28 libcrypto.a
lrwxr-xr-x   1 lbakken  staff       19 Mar 25 06:28 libcrypto.dylib -> libcrypto.1.1.dylib
-r--r--r--   1 lbakken  staff   502872 Mar 31 14:22 libssl.1.1.dylib
-r--r--r--   1 lbakken  staff   723992 Mar 25 06:28 libssl.a
lrwxr-xr-x   1 lbakken  staff       16 Mar 25 06:28 libssl.dylib -> libssl.1.1.dylib
drwxr-xr-x   5 lbakken  staff      160 Mar 31 14:22 pkgconfig

otp-24-crypto-config.log.txt

[DOBRO]

same issue on macOS Big Sur 11.3.1 using kerl:

$ kerl build 24.0

Extracting source code
Building Erlang/OTP 24.0 (24.0), please wait...
Configure failed.
checking for compiler flags for loadable drivers... -Werror=undef -Werror=implicit -Werror=return-type  -Wdeclaration-after-statement -Wall -Wstrict-prototypes -Wmissing-prototypes  -D_THREAD_SAFE -D_REENTRANT -DPOSIX_THREADS -fno-common -g -O2 -fPIC -fno-common
checking for linker for loadable drivers... gcc
checking for linker flags for loadable drivers... -m64 -bundle -bundle_loader /Users/dobro/.kerl/builds/24.0/otp_src_24.0/bin/x86_64-apple-darwin20.4.0/beam.smp
checking for 'runtime library path' linker flag... not found
checking for multiarch directory... not found
checking size of void *... (cached) 8
checking for static zlib... no
checking for OpenSSL header in /usr/local/opt/openssl@1.1... yes
checking for OpenSSL in /usr/local/opt/openssl@1.1... configure: error: neither static nor dynamic crypto library found in /usr/local/opt/openssl@1.1
ERROR: /Users/dobro/.kerl/builds/24.0/otp_src_24.0/lib/crypto/configure failed!

Please see /Users/dobro/.kerl/builds/24.0/otp_build_24.0.log for full details.

$ ls -l /usr/local/opt/openssl@1.1/{lib,lib64,lib/64}
ls: /usr/local/opt/openssl@1.1/lib/64: No such file or directory
ls: /usr/local/opt/openssl@1.1/lib64: No such file or directory
/usr/local/opt/openssl@1.1/lib:
total 15144
drwxr-xr-x  4 dobro  staff      128 Mar 25 16:28 engines-1.1
-r--r--r--  1 dobro  staff  2437024 Mar 29 19:43 libcrypto.1.1.dylib
-r--r--r--  1 dobro  staff  4087176 Mar 25 16:28 libcrypto.a
lrwxr-xr-x  1 dobro  staff       19 Mar 25 16:28 libcrypto.dylib -> libcrypto.1.1.dylib
-r--r--r--  1 dobro  staff   502872 Mar 29 19:43 libssl.1.1.dylib
-r--r--r--  1 dobro  staff   723992 Mar 25 16:28 libssl.a
lrwxr-xr-x  1 dobro  staff       16 Mar 25 16:28 libssl.dylib -> libssl.1.1.dylib
drwxr-xr-x  5 dobro  staff      160 Mar 29 19:43 pkgconfig

config.log

otp_build_24.0.log

[rickard-green]

It seems like a lot of the runs fail due to configure not knowing how to run the C preprocessor. I'm not sure this is the case for all of you. If you set CC to something, try also setting CPP="$CC -E". I haven't got more time to look at this right now, but I'll be back in a couple of hours and will look into it in more detail.

[wojtekmach]

CC was empty for me:

% echo $CC

[essen]

Getting the exact same output as #4821 (comment) but on Mojave. No particular environment/configuration.