Remove a duplicated pattern matching in erl_epmd.erl#1119
Merged
Conversation
`select_best_version` has the duplicated case.
|
Patch has passed first testings and has been assigned to be reviewed I am a script, I am not human |
IngelaAndin
added
team:VM
Contributor
|
Shouldn't this be caught by the compiler? |
Contributor
|
Ideally yes, however the guard complicates matter. The compiler can't coalesce the clauses since it doesn't know what the guard will evaluate to. It could probably probe a bit deeper than it does today and be nominally better. |
Contributor
|
Regardless of the guard's outcome, the two clauses match exactly the same pattern. Or is it more complicated than that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
select_best_versionhas the duplicated case.