New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more EC curves #120

Merged
merged 7 commits into from Jan 17, 2014

Conversation

Projects
None yet
4 participants
@RoadRunnr

RoadRunnr commented Oct 31, 2013

This moves elliptic curve definition from the crypto NIF/OpenSSL into Erlang code, adds the RFC-5639 brainpool curves and makes TLS use them (RFC-7027).

Unit tests for curves where official test vectors exist where added to check that the resulting curve definitions are valid.

@OTP-Maintainer

This comment has been minimized.

Show comment
Hide comment
@OTP-Maintainer

OTP-Maintainer Oct 31, 2013

Patch has passed first testings and has been assigned to be reviewed

OTP-Maintainer commented Oct 31, 2013

Patch has passed first testings and has been assigned to be reviewed

@gustehn

This comment has been minimized.

Show comment
Hide comment
@gustehn

gustehn Nov 1, 2013

Contributor

On the whole I think the patch looks good. The documentation however seems to be "unfinished". It looks like the second functions description is a copy of the first functions and needs to be updated.

Contributor

gustehn commented Nov 1, 2013

On the whole I think the patch looks good. The documentation however seems to be "unfinished". It looks like the second functions description is a copy of the first functions and needs to be updated.

@RoadRunnr

This comment has been minimized.

Show comment
Hide comment
@RoadRunnr

RoadRunnr Nov 17, 2013

Fixed the documentation, please reconsider.

RoadRunnr commented Nov 17, 2013

Fixed the documentation, please reconsider.

@OTP-Maintainer

This comment has been minimized.

Show comment
Hide comment
@OTP-Maintainer

OTP-Maintainer Nov 17, 2013

Patch has passed first testings and has been assigned to be reviewed

OTP-Maintainer commented Nov 17, 2013

Patch has passed first testings and has been assigned to be reviewed

@RoadRunnr

This comment has been minimized.

Show comment
Hide comment
@RoadRunnr

RoadRunnr Dec 30, 2013

rebased to master and added support for disabling GF2m curves. This should allow it to build on recent Centos/RedHat OpenSSL versions (IMHO the better solution to #177).

RoadRunnr commented Dec 30, 2013

rebased to master and added support for disabling GF2m curves. This should allow it to build on recent Centos/RedHat OpenSSL versions (IMHO the better solution to #177).

Andreas Schultz added some commits Oct 30, 2013

Andreas Schultz
crypto: add ECDH test vectors for more curves
Vectors have been taken from NIST's CRYPTOGRAPHIC ALGORITHM VALIDATION
PROGRAM (CAVP) (http://csrc.nist.gov/groups/STM/cavp/)
Andreas Schultz
crypto: move elitic curve definitions from OpenSSL built-ins to Erlang
Decouple eliptic curve definition from OpenSSL and define them in
Erlang.
Andreas Schultz
crypto: add brainpool (RFC 5639) curves
RFC-5649, Section 1, documents the advantages that these curves
might have over others (ANSI, SEC1/2)
Andreas Schultz
crypto: selective support for GF2m curves
Newer OpenSSL versions allow to selectively disable GF2m elliptic curves.
Selectively enable GF2m curves is support for them is available.

@proxyles proxyles merged commit 8837c1b into erlang:master Jan 17, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment